Skip to content

fix(otel): support setting DD_METRICS_OTEL_ENABLED to False#7028

Merged
mabdinur merged 5 commits intomasterfrom
munir/otel-config-fix
Dec 8, 2025
Merged

fix(otel): support setting DD_METRICS_OTEL_ENABLED to False#7028
mabdinur merged 5 commits intomasterfrom
munir/otel-config-fix

Conversation

@mabdinur
Copy link
Copy Markdown
Contributor

@mabdinur mabdinur commented Dec 3, 2025

What does this PR do?

Fixes DD_METRICS_OTEL_ENABLED=false being treated as truthy by using isTrue() to parse the environment variable.

Motivation

The string "false" was truthy, incorrectly enabling OpenTelemetry metrics when disabled.

Plugin Checklist

N/A - Configuration fix.

Additional Notes

  • Updated config.js line 630 to use isTrue(DD_METRICS_OTEL_ENABLED)
  • Added test case in packages/dd-trace/test/opentelemetry/metrics.spec.js

@mabdinur mabdinur requested a review from a team as a code owner December 3, 2025 21:24
@mabdinur mabdinur requested review from BridgeAR and khanayan123 and removed request for a team December 3, 2025 21:24
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 3, 2025

Overall package size

Self size: 13.62 MB
Deduped: 113.82 MB
No deduping: 128.83 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.7.0 | 35.02 MB | 35.02 MB | | @datadog/native-appsec | 10.3.0 | 20.73 MB | 20.74 MB | | @datadog/pprof | 5.12.0 | 11.19 MB | 11.57 MB | | @datadog/native-iast-taint-tracking | 4.1.0 | 9.01 MB | 9.02 MB | | @opentelemetry/resources | 1.30.1 | 557.67 kB | 7.71 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.5.4 | 2.95 MB | 5.83 MB | | @datadog/wasm-js-rewriter | 5.0.1 | 2.82 MB | 3.53 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api-logs | 0.208.0 | 199.48 kB | 1.42 MB | | @opentelemetry/api | 1.9.0 | 1.22 MB | 1.22 MB | | jsonpath-plus | 10.3.0 | 617.18 kB | 1.08 MB | | import-in-the-middle | 1.15.0 | 127.66 kB | 856.24 kB | | lru-cache | 10.4.3 | 804.3 kB | 804.3 kB | | @datadog/openfeature-node-server | 0.2.0 | 118.51 kB | 437.19 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | source-map | 0.7.6 | 185.63 kB | 185.63 kB | | pprof-format | 2.2.1 | 163.06 kB | 163.06 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | @isaacs/ttlcache | 2.1.3 | 90.79 kB | 90.79 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 7.0.5 | 63.38 kB | 63.38 kB | | istanbul-lib-coverage | 3.2.2 | 34.37 kB | 34.37 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.3 | 23.74 kB | 23.74 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | module-details-from-path | 1.0.4 | 3.96 kB | 3.96 kB | | escape-string-regexp | 5.0.0 | 3.66 kB | 3.66 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.83%. Comparing base (0bb1f17) to head (440eb01).
⚠️ Report is 21 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7028      +/-   ##
==========================================
- Coverage   84.94%   84.83%   -0.11%     
==========================================
  Files         514      517       +3     
  Lines       21754    22050     +296     
==========================================
+ Hits        18478    18707     +229     
- Misses       3276     3343      +67     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread packages/dd-trace/src/config.js Outdated
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Dec 3, 2025

Benchmarks

Benchmark execution time: 2025-12-08 16:29:12

Comparing candidate commit 440eb01 in PR branch munir/otel-config-fix with baseline commit 0bb1f17 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 291 metrics, 29 unstable metrics.

khanayan123
khanayan123 previously approved these changes Dec 3, 2025
@mabdinur mabdinur enabled auto-merge (squash) December 3, 2025 23:12
Comment thread packages/dd-trace/src/config.js Outdated
Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de>
@datadog-datadog-prod-us1
Copy link
Copy Markdown

datadog-datadog-prod-us1 Bot commented Dec 7, 2025

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 440eb01 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

Comment thread packages/dd-trace/src/config.js Outdated
BridgeAR
BridgeAR previously approved these changes Dec 8, 2025
@mabdinur mabdinur merged commit f625887 into master Dec 8, 2025
787 checks passed
@mabdinur mabdinur deleted the munir/otel-config-fix branch December 8, 2025 16:41
@dd-octo-sts dd-octo-sts Bot mentioned this pull request Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants