chore(datastreams): separate DSM specific test behavior and add to CODEOWNERS#7076
Conversation
Overall package sizeSelf size: 4.35 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 2.0.0 | 68.46 kB | 797.03 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7076 +/- ##
==========================================
- Coverage 84.78% 84.66% -0.13%
==========================================
Files 521 519 -2
Lines 22155 21914 -241
==========================================
- Hits 18785 18553 -232
+ Misses 3370 3361 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BenchmarksBenchmark execution time: 2025-12-19 19:49:30 Comparing candidate commit 8a22e85 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 290 metrics, 30 unstable metrics. |
This comment has been minimized.
This comment has been minimized.
| "test:openfeature": "mocha -r \"packages/dd-trace/test/setup/mocha.js\" \"packages/dd-trace/test/openfeature/*.spec.js\"", | ||
| "test:openfeature:ci": "nyc --no-clean --include \"packages/dd-trace/src/openfeature/**/*.js\" -- npm run test:openfeature", | ||
| "test:plugins": "mocha -r \"packages/dd-trace/test/setup/mocha.js\" \"packages/datadog-plugin-@($(echo $PLUGINS))/test/**/@($(echo ${SPEC:-'*'})).spec.js\"", | ||
| "test:plugins": "mocha -r \"packages/dd-trace/test/setup/mocha.js\" \"packages/datadog-plugin-@($(echo $PLUGINS))/test/**/@($(echo ${SPEC:-'*'}))*.spec.js\"", |
There was a problem hiding this comment.
This is so i.e. SPEC=sqs will still test sqs.dsm.spec.js, which is consistent with how this would work if SPEC wasn't set.
…:DataDog/dd-trace-js into rob.carlan/DSMON-1162-dsm-test-ownership
wconti27
left a comment
There was a problem hiding this comment.
LGTM, thanks for taking this on!
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
Added to the queue but the mergequeue is not enabled for now.
This pull request was merged directly. |
What does this PR do?
Splits DSM specific tests into their own test files, and updates CODEOWNERS so that the DSM team owns these tests.
Tests still run e.g.:
amqplib: https://github.com/DataDog/dd-trace-js/actions/runs/20139301302/job/57801733910?pr=7076#step:4:492
confluentinc-kafka-javascript: https://github.com/DataDog/dd-trace-js/actions/runs/20139301302/job/57801734114?pr=7076#step:7:410
kafkajs: https://github.com/DataDog/dd-trace-js/actions/runs/20139301302/job/57801734472?pr=7076#step:7:49
Motivation
Plugin Checklist
Additional Notes