Skip to content

chore(datastreams): separate DSM specific test behavior and add to CODEOWNERS#7076

Merged
robcarlan-datadog merged 18 commits intomasterfrom
rob.carlan/DSMON-1162-dsm-test-ownership
Dec 19, 2025
Merged

chore(datastreams): separate DSM specific test behavior and add to CODEOWNERS#7076
robcarlan-datadog merged 18 commits intomasterfrom
rob.carlan/DSMON-1162-dsm-test-ownership

Conversation

@robcarlan-datadog
Copy link
Copy Markdown
Contributor

@robcarlan-datadog robcarlan-datadog commented Dec 10, 2025

What does this PR do?

Splits DSM specific tests into their own test files, and updates CODEOWNERS so that the DSM team owns these tests.

Tests still run e.g.:
amqplib: https://github.com/DataDog/dd-trace-js/actions/runs/20139301302/job/57801733910?pr=7076#step:4:492
confluentinc-kafka-javascript: https://github.com/DataDog/dd-trace-js/actions/runs/20139301302/job/57801734114?pr=7076#step:7:410
kafkajs: https://github.com/DataDog/dd-trace-js/actions/runs/20139301302/job/57801734472?pr=7076#step:7:49

Motivation

Plugin Checklist

Additional Notes

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 10, 2025

Overall package size

Self size: 4.35 MB
Deduped: 5.18 MB
No deduping: 5.18 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 2.0.0 | 68.46 kB | 797.03 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.66%. Comparing base (244b082) to head (8a22e85).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7076      +/-   ##
==========================================
- Coverage   84.78%   84.66%   -0.13%     
==========================================
  Files         521      519       -2     
  Lines       22155    21914     -241     
==========================================
- Hits        18785    18553     -232     
+ Misses       3370     3361       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Dec 10, 2025

Benchmarks

Benchmark execution time: 2025-12-19 19:49:30

Comparing candidate commit 8a22e85 in PR branch rob.carlan/DSMON-1162-dsm-test-ownership with baseline commit 244b082 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 290 metrics, 30 unstable metrics.

@datadog-datadog-prod-us1

This comment has been minimized.

Comment thread package.json
"test:openfeature": "mocha -r \"packages/dd-trace/test/setup/mocha.js\" \"packages/dd-trace/test/openfeature/*.spec.js\"",
"test:openfeature:ci": "nyc --no-clean --include \"packages/dd-trace/src/openfeature/**/*.js\" -- npm run test:openfeature",
"test:plugins": "mocha -r \"packages/dd-trace/test/setup/mocha.js\" \"packages/datadog-plugin-@($(echo $PLUGINS))/test/**/@($(echo ${SPEC:-'*'})).spec.js\"",
"test:plugins": "mocha -r \"packages/dd-trace/test/setup/mocha.js\" \"packages/datadog-plugin-@($(echo $PLUGINS))/test/**/@($(echo ${SPEC:-'*'}))*.spec.js\"",
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so i.e. SPEC=sqs will still test sqs.dsm.spec.js, which is consistent with how this would work if SPEC wasn't set.

@robcarlan-datadog robcarlan-datadog marked this pull request as ready for review December 12, 2025 17:52
@robcarlan-datadog robcarlan-datadog requested review from a team as code owners December 12, 2025 17:52
Copy link
Copy Markdown
Contributor

@wconti27 wconti27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for taking this on!

@robcarlan-datadog
Copy link
Copy Markdown
Contributor Author

/merge

@dd-devflow-routing-codex
Copy link
Copy Markdown

dd-devflow-routing-codex Bot commented Dec 19, 2025

View all feedbacks in Devflow UI.

2025-12-19 16:19:15 UTC ℹ️ Start processing command /merge


2025-12-19 16:19:30 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-12-19 20:14:09 UTC ℹ️ MergeQueue: queue is disabled

Added to the queue but the mergequeue is not enabled for now.


2025-12-19 21:42:39 UTC ℹ️ MergeQueue: This merge request was already merged

This pull request was merged directly.

@robcarlan-datadog robcarlan-datadog merged commit 95d4d26 into master Dec 19, 2025
804 of 807 checks passed
@robcarlan-datadog robcarlan-datadog deleted the rob.carlan/DSMON-1162-dsm-test-ownership branch December 19, 2025 21:42
dd-octo-sts Bot pushed a commit that referenced this pull request Dec 20, 2025
@dd-octo-sts dd-octo-sts Bot mentioned this pull request Dec 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants