test(debugger): fix flaky time budget integration test

[watson]

What does this PR do?

Fixes a flaky integration test for the debugger's time budget mechanism by adding dedicated unit tests with mocked time and removing strict timing assertions from the integration test.

The changes add a new unit test file (collector-deadline.spec.js) that uses mocked process.hrtime.bigint() to deterministically test the deadline checking logic in the snapshot collector. The problematic 1ms budget integration test now only validates behavioral outcomes (that timeout markers appear in snapshots) without asserting on exact execution time, which was causing CI failures.

Motivation

The snapshot-time-budget.spec.js integration test was flaky in GitHub Actions CI environments. The test set a 1ms capture timeout and expected the thread to be paused for ≤16ms (1ms + 15ms tolerance). This assertion frequently failed in CI due to:

• Resource-constrained or throttled GitHub Actions VMs
• Unpredictable execution times in shared infrastructure
• The artificially tight timing constraints (16ms total tolerance)

The flakiness was affecting CI reliability while not providing meaningful test coverage - the important behavior is that timeout markers appear, not the exact pause duration. By adding unit tests with mocked time for the actual deadline logic and relaxing the integration test to only check behavioral outcomes, we maintain full test coverage while eliminating CI flakiness.

[watson]

• test(debugger): fix flaky time budget integration test #7103 👈 (View in Graphite)
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.77%. Comparing base (a8ed0d8) to head (e662378).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7103      +/-   ##
==========================================
- Coverage   84.78%   84.77%   -0.01%     
==========================================
  Files         521      521              
  Lines       22149    22149              
==========================================
- Hits        18778    18776       -2     
- Misses       3371     3373       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

Overall package size

Self size: 3.59 MB
Deduped: 4.47 MB
No deduping: 4.47 MB

Dependency sizes

| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 1.15.0 | 127.66 kB | 856.24 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |

_{🤖 This report was automatically generated by heaviest-objects-in-the-universe}

[pr-commenter]

Benchmarks

Benchmark execution time: 2025-12-16 10:41:14

Comparing candidate commit e662378 in PR branch watson/fix-flaky with baseline commit a8ed0d8 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 291 metrics, 29 unstable metrics.

[BridgeAR]

LGTM, while I would use the other mock

[BridgeAR]

It is possible to also mock this with sinon: sinon.useFakeTimers()

[watson]

I did consider it, but didn't think it was worth while. I just pushed a commit with your suggestion, but I'm not sure the code is that much better. Maybe it's slightly worse depending on how you look at it. Let me know if you prefer it or if I should revert the last commit

[datadog-datadog-prod-us1]

⚠️ Tests

✨ Fix all issues with Cursor

⚠️ Warnings

❄️ 1 New flaky test detected

tests.test_resource_renaming.Test_Resource_Renaming_Stats_Aggregation_Keys.test_stats_aggregation_with_method_and_endpoint[fastify] from system_tests_suite (Datadog) (Fix with Cursor)

AssertionError: Expected 5 hits for GET /resource_renaming/api/users/{param:int}, got 4
assert 4 == 5

self = <tests.test_resource_renaming.Test_Resource_Renaming_Stats_Aggregation_Keys object at 0x7feaa8e61a30>

    @bug(library="python", reason="APMSP-2359")  # trace exporter uses a wrong fieldname
    def test_stats_aggregation_with_method_and_endpoint(self):
        """Test that stats are aggregated by method and endpoint"""
        stats_points = []
        for stats_data in interfaces.library.get_data("/v0.6/stats"):
...

ℹ️ Info

🧪 All tests passed

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: e662378 | Docs | Datadog PR Page | Was this helpful? Give us feedback!}