Skip to content

feat(llmobs): add source:otel tag to evaluations when DD_TRACE_OTEL_ENABLED is set#7113

Merged
ZStriker19 merged 2 commits intomasterfrom
zachg/llmobs_evals_tag_for_ote
Dec 16, 2025
Merged

feat(llmobs): add source:otel tag to evaluations when DD_TRACE_OTEL_ENABLED is set#7113
ZStriker19 merged 2 commits intomasterfrom
zachg/llmobs_evals_tag_for_ote

Conversation

@ZStriker19
Copy link
Copy Markdown
Contributor

@ZStriker19 ZStriker19 commented Dec 15, 2025

Description

Auto-add source:otel tag to LLMObs evaluations when OTel tracing is enabled.

When DD_TRACE_OTEL_ENABLED=true, automatically adds source:otel tag to all submitted evaluations. This allows the backend to wait ~3 minutes for OTel span conversion before discarding unmatched evaluations.

Related: DataDog/dd-trace-py#15538

Changes

  • Add source:otel tag in submitEvaluation() when DD_TRACE_OTEL_ENABLED environment variable is set

Testing

Added unit tests:

  • adds source:otel tag when DD_TRACE_OTEL_ENABLED is set
  • does not add source:otel tag when DD_TRACE_OTEL_ENABLED is not set

Plugin Checklist

Additional Notes

@ZStriker19 ZStriker19 requested a review from a team as a code owner December 15, 2025 20:25
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 15, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.76%. Comparing base (a8ed0d8) to head (a72d4c8).
⚠️ Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
packages/dd-trace/src/llmobs/sdk.js 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7113      +/-   ##
==========================================
- Coverage   84.78%   84.76%   -0.02%     
==========================================
  Files         521      521              
  Lines       22149    22151       +2     
==========================================
- Hits        18778    18776       -2     
- Misses       3371     3375       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 15, 2025

Overall package size

Self size: 4.34 MB
Deduped: 5.22 MB
No deduping: 5.22 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 1.15.0 | 127.66 kB | 856.24 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link
Copy Markdown
Collaborator

@sabrenner sabrenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple nits!

Comment thread packages/dd-trace/test/llmobs/sdk/index.spec.js Outdated
Comment thread packages/dd-trace/src/llmobs/sdk.js Outdated
Comment thread packages/dd-trace/test/llmobs/sdk/index.spec.js Outdated
@ZStriker19 ZStriker19 requested a review from sabrenner December 16, 2025 20:26
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Dec 16, 2025

Benchmarks

Benchmark execution time: 2025-12-16 20:34:43

Comparing candidate commit a72d4c8 in PR branch zachg/llmobs_evals_tag_for_ote with baseline commit a8ed0d8 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 291 metrics, 29 unstable metrics.

@ZStriker19 ZStriker19 enabled auto-merge (squash) December 16, 2025 20:45
@ZStriker19 ZStriker19 merged commit e9493e1 into master Dec 16, 2025
792 of 794 checks passed
@ZStriker19 ZStriker19 deleted the zachg/llmobs_evals_tag_for_ote branch December 16, 2025 20:50
dd-octo-sts Bot pushed a commit that referenced this pull request Dec 17, 2025
@dd-octo-sts dd-octo-sts Bot mentioned this pull request Dec 17, 2025
BridgeAR pushed a commit that referenced this pull request Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants