Move vendored dependencies to non-standard folder#7115
Conversation
Overall package sizeSelf size: 4.34 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 1.15.0 | 127.66 kB | 856.24 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🔗 Commit SHA: 938d7f6 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
rochdev
force-pushed
the
vendor-relative
branch
from
cb10a2e to
ba9935d
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7115 +/- ##
==========================================
+ Coverage 84.78% 84.85% +0.07%
==========================================
Files 521 516 -5
Lines 22149 22006 -143
==========================================
- Hits 18778 18674 -104
+ Misses 3371 3332 -39 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| const net = require('net') | ||
| const zlib = require('zlib') | ||
| const { Profile } = require('pprof-format') | ||
| const { Profile } = require('../../vendor/dist/pprof-format') |
There was a problem hiding this comment.
This is really annoying. I'm almost considering a build step just to not have to do this
There was a problem hiding this comment.
Agreed. I think we can look into this again at a later point
There was a problem hiding this comment.
I'm almost considering a build step just to not have to do this
That should be how we do this anyway, but unfortunately it is not currently possible as the code is not modularized, so we can't bundle individual features properly, and bundling a single output is unacceptable because of Serverless.
This is required to make sure yarn 2+ continues to work as expected. It would otherwise remove the node_modules folder during install. That would break dd-trace usage.
This is required to make sure yarn 2+ continues to work as expected. It would otherwise remove the node_modules folder during install. That would break dd-trace usage.
This is required to make sure yarn 2+ continues to work as expected. It would otherwise remove the node_modules folder during install. That would break dd-trace usage.
3 participants
What does this PR do?
Move vendored dependencies to non-standard folder.
Motivation
Yarn v2+ deletes all
node_modulesfolder in the entire tree of dependencies, making it impossible to write standard Node code.