Skip to content

[DI] add process tags to dynamic instrumentation#7132

Merged
tlhunter merged 1 commit intomasterfrom
tlhunter/process-tags-dynamic-instrumentation
Dec 22, 2025
Merged

[DI] add process tags to dynamic instrumentation#7132
tlhunter merged 1 commit intomasterfrom
tlhunter/process-tags-dynamic-instrumentation

Conversation

@tlhunter
Copy link
Copy Markdown
Member

@tlhunter tlhunter commented Dec 17, 2025

What does this PR do?

Motivation

  • help with process renaming

@tlhunter tlhunter added the AI Generated Largely based on code generated by an AI or LLM. This label is the same across all dd-trace-* repos label Dec 17, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 17, 2025

Overall package size

Self size: 4.35 MB
Deduped: 5.18 MB
No deduping: 5.18 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 2.0.0 | 68.46 kB | 797.03 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.79%. Comparing base (edfc7c6) to head (ac05a9e).
⚠️ Report is 11 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7132   +/-   ##
=======================================
  Coverage   84.78%   84.79%           
=======================================
  Files         521      521           
  Lines       22155    22157    +2     
=======================================
+ Hits        18785    18787    +2     
  Misses       3370     3370           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Dec 17, 2025

Benchmarks

Benchmark execution time: 2025-12-18 21:18:50

Comparing candidate commit ac05a9e in PR branch tlhunter/process-tags-dynamic-instrumentation with baseline commit edfc7c6 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 293 metrics, 27 unstable metrics.

@tlhunter tlhunter marked this pull request as ready for review December 17, 2025 22:59
@tlhunter tlhunter requested review from a team as code owners December 17, 2025 22:59
@datadog-datadog-prod-us1

This comment has been minimized.

@tlhunter tlhunter force-pushed the tlhunter/process-tags-dynamic-instrumentation branch 4 times, most recently from 2882395 to 7cab70c Compare December 18, 2025 03:45
@watson watson added the debugger Dynamic Instrumentation & Live Debugger label Dec 18, 2025
@watson
Copy link
Copy Markdown
Collaborator

watson commented Dec 18, 2025

@tlhunter this PR could do with a better description. I'm not sure what process tags is and why it's added to the snapshot

@tlhunter tlhunter force-pushed the tlhunter/process-tags-dynamic-instrumentation branch from fc68c4a to ac05a9e Compare December 18, 2025 21:09
@tlhunter
Copy link
Copy Markdown
Member Author

Just rebased on the chai -> assert migration

Copy link
Copy Markdown
Collaborator

@watson watson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer a few minor things to be cleaned up, but since the holidays are coming up, I will not want to be a blocker, so I'll approve this PR (as it's just minor optimizations). It would be best to just fix them, and feel free to do so and to get someone else to approve the PR afterwards, but it could also be fixed in a follow-up PR if you prefer.

Comment thread integration-tests/debugger/basic.spec.js
Comment thread packages/dd-trace/src/debugger/devtools_client/index.js
Comment thread packages/dd-trace/test/process-tags.spec.js
Comment thread packages/dd-trace/test/process-tags.spec.js
Comment thread packages/dd-trace/test/process-tags.spec.js
@tlhunter tlhunter merged commit 7a64f41 into master Dec 22, 2025
988 of 992 checks passed
@tlhunter tlhunter deleted the tlhunter/process-tags-dynamic-instrumentation branch December 22, 2025 14:49
@tlhunter
Copy link
Copy Markdown
Member Author

@watson @BridgeAR I'm doing a lot of work in this area right now so I'll address the nits in the PR I'm working on today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI Generated Largely based on code generated by an AI or LLM. This label is the same across all dd-trace-* repos debugger Dynamic Instrumentation & Live Debugger semver-minor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants