Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7134 +/- ##
==========================================
+ Coverage 77.88% 84.78% +6.90%
==========================================
Files 379 521 +142
Lines 17620 22155 +4535
==========================================
+ Hits 13723 18785 +5062
+ Misses 3897 3370 -527 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Overall package sizeSelf size: 4.35 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 2.0.0 | 68.46 kB | 797.03 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
This comment has been minimized.
This comment has been minimized.
BenchmarksBenchmark execution time: 2025-12-18 18:47:03 Comparing candidate commit 2c6382a in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 287 metrics, 33 unstable metrics. |
| sinon.assert.calledOnceWithMatch(addSub, channelName) | ||
| sinon.assert.calledOnceWithExactly(getAndRegisterSubscription, { channelName, tag, tagKey: TagKey.SOURCE_TYPE }) |
There was a problem hiding this comment.
nit: why is one converted to calledOnceWithMatch and the other to calledOnceWithExactly ? just because otherwise the test fails ?
| assert.strictEqual(rootSpan.setTag.getCall(0).calledWithExactly('usr.id', '123'), true) | ||
| assert.strictEqual(rootSpan.setTag.getCall(1).calledWithExactly('usr.email', 'a@b.c'), true) | ||
| assert.strictEqual(rootSpan.setTag.getCall(2).calledWithExactly('usr.custom', 'hello'), true) | ||
| assert.strictEqual(rootSpan.setTag.getCall(3).calledWithExactly('usr.session_id', '133769'), true) | ||
| assert.strictEqual(rootSpan.setTag.getCall(4).calledWithExactly('_dd.appsec.user.collection_mode', 'sdk'), true) |
There was a problem hiding this comment.
Doesn't that work better ?
sinon.assert.calledWithExactly(rootSpan.setTag.getCall(0), 'usr.id', '123')There was a problem hiding this comment.
Both works. I did not look into all transformations if they are perfect as long as they keep the overall behavior as expected.
watson
left a comment
watson
left a comment
There was a problem hiding this comment.
Great work 💯
The comments apply to all changes, but I mostly only added them the first time I saw a specific pattern.
Automated rewrites including a lint:fix call.
This reverts commit 80fdb01.
BridgeAR
force-pushed
the
BridgeAR/2025-12-18-rewrite-chai-to-assert
branch
from
284584a to
2c6382a
Compare
Automated rewrites including a lint:fix call. Afterwards manual fixes and small improvements.
Automated rewrites including a lint:fix call. Afterwards manual fixes and small improvements.
Automated rewrites including a lint:fix call. Afterwards manual fixes and small improvements.
3 participants
These changes are done with a script. The script is visible in another commit that is reverted.
Manual fixes will be pushed after checking test failures.