refactor(config): use getEnv instead of getEnvironmentVariables#7147
Merged
refactor(config): use getEnv instead of getEnvironmentVariables#7147
Conversation
This comment has been minimized.
This comment has been minimized.
Contributor
Overall package sizeSelf size: 4.36 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 2.0.0 | 68.46 kB | 797.03 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7147 +/- ##
==========================================
- Coverage 84.78% 84.77% -0.02%
==========================================
Files 521 521
Lines 22155 22224 +69
==========================================
+ Hits 18785 18840 +55
- Misses 3370 3384 +14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BridgeAR
requested changes
Dec 19, 2025
Member
BridgeAR
left a comment
BridgeAR
left a comment
There was a problem hiding this comment.
Mostly looking good, while the self part should be reverted in my opinion.
Comment on lines
+1512
to
+1513
| const DD_GIT_FOLDER_PATH = getEnv('DD_GIT_FOLDER_PATH') | ||
| const gitFolderPath = DD_GIT_FOLDER_PATH ?? path.join(process.cwd(), '.git') |
watson
force-pushed
the
watson/config-cleanup
branch
from
72ef59e to
b21af32
Compare
watson
changed the title
Cast Config instance to Record<string, any> where dynamic properties from config_defaults are accessed. Resolves TypeScript errors without runtime overhead.
This reverts commit e8cf0e30e03bc068d50a64fd76a62d1ff8c53182.
watson
force-pushed
the
watson/config-cleanup
branch
from
b21af32 to
d7d4f25
Compare
BridgeAR
approved these changes
Dec 19, 2025
Merged
nina9753
pushed a commit
that referenced
this pull request
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do?
This PR refactors the
Configclass to standardize environment variable access by replacinggetEnvironmentVariables()withgetEnv()for consistency throughout the codebase.Motivation
Using a consistent method for environment variable access improves code maintainability and readability.