Default to zstd compression for profile uploads on Node.js 24+#7172
Merged
Default to zstd compression for profile uploads on Node.js 24+#7172
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7172 +/- ##
=======================================
Coverage 84.55% 84.55%
=======================================
Files 532 532
Lines 22641 22642 +1
=======================================
+ Hits 19144 19145 +1
Misses 3497 3497 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Overall package sizeSelf size: 4.38 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 2.0.0 | 68.46 kB | 797.03 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
This comment has been minimized.
This comment has been minimized.
3037557 to
7001200
Compare
BridgeAR
approved these changes
Jan 9, 2026
Merged
nina9753
pushed a commit
that referenced
this pull request
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Default to zstd compression for profile uploads on Node.js 24+
Motivation
We want to make zstd default. zstd is used by default by many other language profilers already and is well supported in the Datadog backend. We could default to ztsd on all supported Node.js versions as we ship a Rust zstd compressor for older Node.js versions, but on 24+ we use the built-in one that runs asynchronously on libuv worker threads, just as gzip does. This is a less disruptive choice than making it default on every version, as older versions would use the Rust zstd compressor that would run on the event loop thread.
Additional Notes
Jira: PROF-11927