Skip to content

Fix: updating remote config manager to send process_tags as an array#7180

Merged
crysmags merged 6 commits intomasterfrom
crysmags/processtags-fix
Jan 6, 2026
Merged

Fix: updating remote config manager to send process_tags as an array#7180
crysmags merged 6 commits intomasterfrom
crysmags/processtags-fix

Conversation

@crysmags
Copy link
Copy Markdown
Collaborator

@crysmags crysmags commented Jan 6, 2026

What does this PR do?

Fixes a bug in remote config where the tracer was sending process_tags as an object, but the Agent expects an array of strings.

[Error: [RC] Error in request]
NoTransmitError: Error from http://127.0.0.1:8136/v0.7/config: 400 Bad Request. Response from the endpoint: "json: cannot unmarshal object into Go struct field ClientTracer.client.client_tracer.process_tags of type []string
"

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 6, 2026

Overall package size

Self size: 4.39 MB
Deduped: 5.21 MB
No deduping: 5.21 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 2.0.0 | 68.46 kB | 797.03 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@crysmags crysmags changed the title updating remote config manager to use tagsArray Fix: updating remote config manager to send process_tags as an array Jan 6, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.51%. Comparing base (2681a5e) to head (431a05f).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7180   +/-   ##
=======================================
  Coverage   84.51%   84.51%           
=======================================
  Files         525      525           
  Lines       22492    22489    -3     
=======================================
- Hits        19008    19007    -1     
+ Misses       3484     3482    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-datadog-prod-us1

This comment has been minimized.

@crysmags crysmags marked this pull request as ready for review January 6, 2026 17:02
@crysmags crysmags requested review from a team as code owners January 6, 2026 17:02
@crysmags crysmags requested review from khanayan123 and removed request for a team January 6, 2026 17:02
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Jan 6, 2026

Benchmarks

Benchmark execution time: 2026-01-06 20:59:10

Comparing candidate commit 431a05f in PR branch crysmags/processtags-fix with baseline commit 2681a5e in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 293 metrics, 27 unstable metrics.

Copy link
Copy Markdown
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The serialize method is now not used anymore as far as I can tell (besides in tests)

Comment thread packages/dd-trace/src/process-tags/index.js Outdated
@crysmags crysmags merged commit 11e33bf into master Jan 6, 2026
794 checks passed
@crysmags crysmags deleted the crysmags/processtags-fix branch January 6, 2026 21:16
@dd-octo-sts dd-octo-sts Bot mentioned this pull request Jan 12, 2026
dd-octo-sts Bot pushed a commit that referenced this pull request Jan 12, 2026
…7180)

* updating remote config manager to use tagsArray and test to expect an array

* removing serialize function and corresponding tests since it is no longer used.
nina9753 pushed a commit that referenced this pull request Jan 15, 2026
…7180)

* updating remote config manager to use tagsArray and test to expect an array

* removing serialize function and corresponding tests since it is no longer used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants