Skip to content

ci: update openldap image with maintained one#7181

Merged
BridgeAR merged 2 commits intomasterfrom
BridgeAR/2026-01-07-replace-openldap-image
Jan 7, 2026
Merged

ci: update openldap image with maintained one#7181
BridgeAR merged 2 commits intomasterfrom
BridgeAR/2026-01-07-replace-openldap-image

Conversation

@BridgeAR
Copy link
Copy Markdown
Member

@BridgeAR BridgeAR commented Jan 6, 2026

Alternative to #6569
Closes: #6569

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 6, 2026

Overall package size

Self size: 4.39 MB
Deduped: 5.21 MB
No deduping: 5.21 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 2.0.0 | 68.46 kB | 797.03 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@datadog-datadog-prod-us1

This comment has been minimized.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.51%. Comparing base (2681a5e) to head (92f190a).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7181   +/-   ##
=======================================
  Coverage   84.51%   84.51%           
=======================================
  Files         525      525           
  Lines       22492    22492           
=======================================
  Hits        19008    19008           
  Misses       3484     3484           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Jan 6, 2026

Benchmarks

Benchmark execution time: 2026-01-06 19:17:06

Comparing candidate commit 92f190a in PR branch BridgeAR/2026-01-07-replace-openldap-image with baseline commit 2681a5e in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 288 metrics, 32 unstable metrics.

@BridgeAR BridgeAR force-pushed the BridgeAR/2026-01-07-replace-openldap-image branch from 6c4b220 to 166f15b Compare January 6, 2026 17:49
@BridgeAR BridgeAR force-pushed the BridgeAR/2026-01-07-replace-openldap-image branch from 166f15b to 91326dc Compare January 6, 2026 18:07
@BridgeAR BridgeAR marked this pull request as ready for review January 6, 2026 18:58
@BridgeAR BridgeAR requested review from a team as code owners January 6, 2026 18:58
Comment on lines +83 to +84
- '1389:389'
- '1636:636'
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: doesn't that mean the opensuse image is running on root ? is that gonna be a sec problem ? prob not?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is the default port for openldap and the other port is not supported by the container by default. It should not be a security concern either.

services:
openldap:
image: bitnamilegacy/openldap:latest
image: registry.opensuse.org/opensuse/openldap
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we pin it to a specific hash if that's even possible ? the internal sec team always come asking us to use pinned deps right

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with that and think we should handle it for all of our containers in a separate step

Copy link
Copy Markdown
Member

@simon-id simon-id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two comments, but i'll let you decide if it's worth spending time on them. So preemptive approval

@BridgeAR BridgeAR merged commit a44e8f9 into master Jan 7, 2026
892 of 895 checks passed
@BridgeAR BridgeAR deleted the BridgeAR/2026-01-07-replace-openldap-image branch January 7, 2026 20:57
BridgeAR added a commit that referenced this pull request Jan 8, 2026
watson pushed a commit that referenced this pull request Jan 8, 2026
@dd-octo-sts dd-octo-sts Bot mentioned this pull request Jan 12, 2026
dd-octo-sts Bot pushed a commit that referenced this pull request Jan 12, 2026
* ci: update openldap image with opensuse image
* fix local image as well
dd-octo-sts Bot pushed a commit that referenced this pull request Jan 12, 2026
nina9753 pushed a commit that referenced this pull request Jan 15, 2026
* ci: update openldap image with opensuse image
* fix local image as well
nina9753 pushed a commit that referenced this pull request Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants