ci: update openldap image with maintained one#7181
Conversation
Overall package sizeSelf size: 4.39 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 2.0.0 | 68.46 kB | 797.03 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7181 +/- ##
=======================================
Coverage 84.51% 84.51%
=======================================
Files 525 525
Lines 22492 22492
=======================================
Hits 19008 19008
Misses 3484 3484 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BenchmarksBenchmark execution time: 2026-01-06 19:17:06 Comparing candidate commit 92f190a in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 288 metrics, 32 unstable metrics. |
6c4b220 to
166f15b
Compare
166f15b to
91326dc
Compare
| - '1389:389' | ||
| - '1636:636' |
There was a problem hiding this comment.
nit: doesn't that mean the opensuse image is running on root ? is that gonna be a sec problem ? prob not?
There was a problem hiding this comment.
It is the default port for openldap and the other port is not supported by the container by default. It should not be a security concern either.
| services: | ||
| openldap: | ||
| image: bitnamilegacy/openldap:latest | ||
| image: registry.opensuse.org/opensuse/openldap |
There was a problem hiding this comment.
should we pin it to a specific hash if that's even possible ? the internal sec team always come asking us to use pinned deps right
There was a problem hiding this comment.
I agree with that and think we should handle it for all of our containers in a separate step
simon-id
left a comment
There was a problem hiding this comment.
two comments, but i'll let you decide if it's worth spending time on them. So preemptive approval
* ci: update openldap image with opensuse image * fix local image as well
* ci: update openldap image with opensuse image * fix local image as well
Alternative to #6569
Closes: #6569