Skip to content

feat(iast): Improve weak hash detection accuracy for node-preload#7230

Merged
CarlesDD merged 1 commit intomasterfrom
ccapell/iast-add-weak-hash-exclusion-node-preload
Jan 13, 2026
Merged

feat(iast): Improve weak hash detection accuracy for node-preload#7230
CarlesDD merged 1 commit intomasterfrom
ccapell/iast-add-weak-hash-exclusion-node-preload

Conversation

@CarlesDD
Copy link
Copy Markdown
Contributor

@CarlesDD CarlesDD commented Jan 13, 2026

What does this PR do?

Ignore weak hash vulnerabilities detected in node-preload as it is safe, and it's generating noise with false positives

Motivation

Improve weak hash IAST detection accuracy

Additional notes

Safe usage of sha1 in node-preload: https://github.com/cfware/node-preload/blob/master/preload-list-env.js#L5

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.56%. Comparing base (411eb57) to head (730979d).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7230   +/-   ##
=======================================
  Coverage   84.56%   84.56%           
=======================================
  Files         532      532           
  Lines       22651    22651           
=======================================
  Hits        19154    19154           
  Misses       3497     3497           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@CarlesDD CarlesDD marked this pull request as ready for review January 13, 2026 14:30
@CarlesDD CarlesDD requested a review from a team as a code owner January 13, 2026 14:30
@github-actions
Copy link
Copy Markdown
Contributor

Overall package size

Self size: 4.39 MB
Deduped: 5.21 MB
No deduping: 5.21 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 2.0.0 | 68.46 kB | 797.03 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@CarlesDD CarlesDD enabled auto-merge (squash) January 13, 2026 14:56
@CarlesDD CarlesDD merged commit 61f0b12 into master Jan 13, 2026
830 of 832 checks passed
@CarlesDD CarlesDD deleted the ccapell/iast-add-weak-hash-exclusion-node-preload branch January 13, 2026 15:04
@dd-octo-sts dd-octo-sts Bot mentioned this pull request Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants