chore(tests): add type annotations to integration test helpers by watson · Pull Request #7240 · DataDog/dd-trace-js

watson · 2026-01-14T11:21:07Z

What does this PR do?

As the title says

Motivation

I wanted to get integration-tests/helpers/index.js to a clean state where there's no more type errors.

watson · 2026-01-14T11:21:42Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2026-01-14T11:21:52Z

Overall package size

Self size: 4.39 MB
Deduped: 5.21 MB
No deduping: 5.21 MB

Dependency sizes

| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 2.0.0 | 68.46 kB | 797.03 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |

_{🤖 This report was automatically generated by heaviest-objects-in-the-universe}

codecov · 2026-01-14T11:22:19Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.39%. Comparing base (0b7c8cc) to head (5d3f175).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff             @@
##           master    #7240       +/-   ##
===========================================
- Coverage   85.13%   72.39%   -12.74%     
===========================================
  Files         532      204      -328     
  Lines       22654     7840    -14814     
===========================================
- Hits        19287     5676    -13611     
+ Misses       3367     2164     -1203

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

pr-commenter · 2026-01-14T11:31:48Z

Benchmarks

Benchmark execution time: 2026-01-16 09:17:45

Comparing candidate commit 5d3f175 in PR branch watson/DEBUG-4402/clean-up-ts-errors with baseline commit 0b7c8cc in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 288 metrics, 32 unstable metrics.

BridgeAR

Small suggestion for improvement about the port and it weakens some checks, which are probably not problematic, I thought I just ask.

Otherwise LGTM

BridgeAR · 2026-01-15T11:04:01Z

+    if (typeof actualMetadata.result !== 'string') {
+      throw new assert.AssertionError({ message: 'result field should be a string' })
+    }
+    if (typeof actualMetadata.result_class !== 'string') {


These do not verify that the string has to be non empty. Is that intentional?

My thought was that it was covered by the assertions below, but I see now that actualMetadata.result_reason isn't. I'll update the PR.

Background: The reason why I made this change was because TS wasn't sure that these were strings, so I needed an assertion that checked that they were strings so that TS wouldn't complain when I used them as input to validResults.includes and validResultClasses.includes. I'm not a fan of the way I fixed this, but I couldn't come up with a better approach. But let me know if you have any ideas.

BridgeAR · 2026-01-15T11:04:34Z

@@ -217,7 +217,7 @@ function spawnProc (filename, options = {}, stdioHandler, stderrHandler) {

  return new Promise((resolve, reject) => {
    proc
-      .on('message', ({ port }) => {
+      .on('message', (/** @type {{ port?: unknown }} */ { port }) => {


Should port not just be a number (or potentially a string?)

I used unknown due to the type check below. The type check below is useful for catching runtime errors, so I don't want to remove that. I feels kinda weird to set it to number and then also have the type check. WDYT?

BridgeAR · 2026-01-15T11:05:51Z

+    for (let i = 0; i < args.length; i += 2) {
+      expectedPoints.push({
+        name: 'library_entrypoint.' + args[i],
+        tags: args[i + 1].split(',').filter(Boolean)
+      })


watson self-assigned this Jan 14, 2026

watson added the semver-patch label Jan 14, 2026

watson mentioned this pull request Jan 14, 2026

refactor(test): improve type safety for spawned process URLs #7219

Merged

This comment has been minimized.

Sign in to view

watson changed the base branch from watson/DEBUG-4402/spawn-proc-refactor to graphite-base/7240 January 14, 2026 11:37

watson force-pushed the watson/DEBUG-4402/clean-up-ts-errors branch from 78f4210 to cde62ed Compare January 14, 2026 11:38

watson force-pushed the graphite-base/7240 branch from 09f5e10 to 2fe3616 Compare January 14, 2026 11:38

watson changed the base branch from graphite-base/7240 to watson/DEBUG-4402/spawn-proc-refactor January 14, 2026 11:38

watson force-pushed the watson/DEBUG-4402/clean-up-ts-errors branch from cde62ed to 3d6a7b4 Compare January 14, 2026 11:40

watson force-pushed the watson/DEBUG-4402/spawn-proc-refactor branch from 2fe3616 to 02625e4 Compare January 14, 2026 11:40

watson force-pushed the watson/DEBUG-4402/clean-up-ts-errors branch from 3d6a7b4 to 53223a1 Compare January 14, 2026 11:48

watson force-pushed the watson/DEBUG-4402/spawn-proc-refactor branch from 02625e4 to dbfb772 Compare January 14, 2026 11:48

watson changed the base branch from watson/DEBUG-4402/spawn-proc-refactor to graphite-base/7240 January 14, 2026 13:34

watson force-pushed the watson/DEBUG-4402/clean-up-ts-errors branch from 53223a1 to 87c16a4 Compare January 14, 2026 14:24

watson changed the base branch from graphite-base/7240 to watson/DEBUG-4402/spawn-proc-refactor January 14, 2026 14:24

Base automatically changed from watson/DEBUG-4402/spawn-proc-refactor to master January 14, 2026 15:14

watson force-pushed the watson/DEBUG-4402/clean-up-ts-errors branch from 87c16a4 to 79f75bc Compare January 14, 2026 15:15

watson marked this pull request as ready for review January 14, 2026 15:15

watson requested a review from a team as a code owner January 14, 2026 15:15

BridgeAR reviewed Jan 15, 2026

View reviewed changes

watson added 2 commits January 16, 2026 10:08

chore(tests): add type annotations to integration test helpers

9a36367

Address review comments

5d3f175

watson force-pushed the watson/DEBUG-4402/clean-up-ts-errors branch from 79f75bc to 5d3f175 Compare January 16, 2026 09:08

watson requested a review from BridgeAR January 16, 2026 09:09

BridgeAR approved these changes Jan 16, 2026

View reviewed changes

watson merged commit 3d6e608 into master Jan 16, 2026
796 checks passed

watson deleted the watson/DEBUG-4402/clean-up-ts-errors branch January 16, 2026 11:43

dd-octo-sts Bot pushed a commit that referenced this pull request Jan 17, 2026

chore(tests): add type annotations to integration test helpers (#7240)

d7d9bef

dd-octo-sts Bot mentioned this pull request Jan 17, 2026

v5.83.0 proposal #7270

Merged

BridgeAR pushed a commit that referenced this pull request Jan 22, 2026

chore(tests): add type annotations to integration test helpers (#7240)

f80a9e4

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(tests): add type annotations to integration test helpers#7240

chore(tests): add type annotations to integration test helpers#7240
watson merged 2 commits intomasterfrom
watson/DEBUG-4402/clean-up-ts-errors

watson commented Jan 14, 2026

Uh oh!

watson commented Jan 14, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jan 14, 2026 •

edited

Loading

Uh oh!

codecov Bot commented Jan 14, 2026 •

edited

Loading

Uh oh!

This comment has been minimized.

pr-commenter Bot commented Jan 14, 2026 •

edited

Loading

Uh oh!

BridgeAR left a comment

Uh oh!

BridgeAR Jan 15, 2026

Uh oh!

watson Jan 15, 2026

Uh oh!

watson Jan 16, 2026

Uh oh!

BridgeAR Jan 15, 2026

Uh oh!

watson Jan 16, 2026

Uh oh!

BridgeAR Jan 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

watson commented Jan 14, 2026

What does this PR do?

Motivation

Uh oh!

watson commented Jan 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jan 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Overall package size

Uh oh!

codecov Bot commented Jan 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

This comment has been minimized.

pr-commenter Bot commented Jan 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Uh oh!

BridgeAR left a comment

Choose a reason for hiding this comment

Uh oh!

BridgeAR Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

watson Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

watson Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

BridgeAR Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

watson Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

BridgeAR Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

watson commented Jan 14, 2026 •

edited

Loading

github-actions Bot commented Jan 14, 2026 •

edited

Loading

codecov Bot commented Jan 14, 2026 •

edited

Loading

pr-commenter Bot commented Jan 14, 2026 •

edited

Loading