[test optimization] Fix quarantine + EFD#7491
Conversation
Overall package sizeSelf size: 4.59 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 2.0.6 | 81.92 kB | 813.08 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7491 +/- ##
==========================================
- Coverage 80.28% 80.27% -0.02%
==========================================
Files 731 731
Lines 31152 31156 +4
==========================================
Hits 25009 25009
- Misses 6143 6147 +4 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
BenchmarksBenchmark execution time: 2026-02-12 09:44:41 Comparing candidate commit 7901688 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 233 metrics, 27 unstable metrics. |
| : path.relative(sourceRoot, testSuiteAbsolutePath) | ||
|
|
||
| return testSuitePath.replace(path.sep, '/') | ||
| return testSuitePath.replaceAll(path.sep, '/') |
There was a problem hiding this comment.
unrelated improvement
| const quarantinedTests = tests.filter( | ||
| test => test.meta[TEST_NAME] === 'quarantine tests can quarantine a test' | ||
| ) | ||
| assert.ok(quarantinedTests.length > 1, 'quarantined test should have been retried by ATR') |
There was a problem hiding this comment.
Unrelated to this PR, but what's the motivation of retrying quarantined tests? Does this bring any value?
There was a problem hiding this comment.
It brings value, but one could argue that it might not be enough for the cost. The value is getting a stronger signal about how the test behaves
2 participants
What does this PR do?
Fix some edge cases where quarantined tests run with EFD would result in us not correctly ignoring quarantined test failures.
Motivation
Make sure quarantine and EFD work correctly.