Skip to content

chore: add add-new-instrumentation agent skill#7564

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits intomasterfrom
watson/skills
Feb 18, 2026
Merged

chore: add add-new-instrumentation agent skill#7564
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits intomasterfrom
watson/skills

Conversation

@watson
Copy link
Copy Markdown
Collaborator

@watson watson commented Feb 18, 2026

What does this PR do?

Adds an add-new-instrumentation agent skill that provides a step-by-step guide for creating new dd-trace instrumentation files and plugins. The skill is stored under .agents/skills/add-new-instrumentation/SKILL.md and symlinked into both .claude/skills/ and .cursor/skills/, making it available to Claude and Cursor AI agents alike.

Motivation

Adding new instrumentation requires coordinating changes across several files (datadog-instrumentations/, datadog-plugin-*/, plugins/index.js, index.d.ts, docs/API.md, CI config, etc.). Encoding this workflow as a shared skill gives AI agents consistent, up-to-date guidance so they can scaffold new integrations correctly without missing steps.

Additional Notes

.gitignore is updated to stop ignoring .claude/skills/ and .cursor/skills/ so the symlinks are tracked in version control, while other Claude/Cursor local settings (e.g. settings.local.json) remain ignored.

Adds a shared skill guide for creating new dd-trace instrumentations
and plugins. The skill lives under `.agents/skills/` and is symlinked
into both `.claude/skills/` and `.cursor/skills/` so it's available
to all AI agents. Updates `.gitignore` to track the skill files while
continuing to exclude other Claude/Cursor settings.
@watson watson requested a review from a team as a code owner February 18, 2026 15:31
Copy link
Copy Markdown
Collaborator Author

watson commented Feb 18, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@watson watson self-assigned this Feb 18, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 18, 2026

Overall package size

Self size: 4.68 MB
Deduped: 5.52 MB
No deduping: 5.52 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 2.0.6 | 81.92 kB | 813.08 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@datadog-official
Copy link
Copy Markdown

datadog-official Bot commented Feb 18, 2026

⚠️ Tests

Fix all issues with BitsAI or with Cursor

⚠️ Warnings

❄️ 1 New flaky test detected

cypress@latest esm instruments tests with the APM protocol (old agents) from integration-tests/cypress/cypress.spec.js (Datadog) (Fix with Cursor)
Expected values to be partially and strictly deep-equal:
+ actual - expected

+ undefined
- {
-   meta: {
-     'test.codeowners': '["@datadog-dd-trace-js"]',
-     'test.framework': 'cypress',
-     'test.name': 'basic pass suite can pass',
-     'test.status': 'pass',
...

ℹ️ Info

🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 7d552c0 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Feb 18, 2026

Benchmarks

Benchmark execution time: 2026-02-18 16:31:54

Comparing candidate commit 7d552c0 in PR branch watson/skills with baseline commit 416a1d9 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 230 metrics, 30 unstable metrics.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.29%. Comparing base (416a1d9) to head (7d552c0).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7564   +/-   ##
=======================================
  Coverage   80.29%   80.29%           
=======================================
  Files         732      732           
  Lines       31468    31468           
=======================================
+ Hits        25266    25267    +1     
+ Misses       6202     6201    -1     
Flag Coverage Δ
aiguard-macos 39.01% <ø> (-0.11%) ⬇️
aiguard-ubuntu 39.13% <ø> (-0.11%) ⬇️
aiguard-windows 38.87% <ø> (-0.11%) ⬇️
apm-capabilities-tracing-macos 48.34% <ø> (-0.05%) ⬇️
apm-capabilities-tracing-ubuntu 48.42% <ø> (ø)
apm-capabilities-tracing-windows 48.11% <ø> (-0.01%) ⬇️
apm-integrations-child-process 38.58% <ø> (-0.11%) ⬇️
apm-integrations-couchbase-18 37.48% <ø> (-0.10%) ⬇️
apm-integrations-couchbase-eol 37.82% <ø> (-0.25%) ⬇️
apm-integrations-oracledb 37.81% <ø> (-0.10%) ⬇️
appsec-express 55.66% <ø> (-0.07%) ⬇️
appsec-fastify 51.97% <ø> (-0.07%) ⬇️
appsec-graphql 52.14% <ø> (-0.07%) ⬇️
appsec-kafka 44.58% <ø> (-0.09%) ⬇️
appsec-ldapjs 44.18% <ø> (-0.09%) ⬇️
appsec-lodash 43.86% <ø> (-0.08%) ⬇️
appsec-macos 58.75% <ø> (-0.07%) ⬇️
appsec-mongodb-core 48.97% <ø> (-0.08%) ⬇️
appsec-mongoose 49.77% <ø> (-0.08%) ⬇️
appsec-mysql 51.14% <ø> (-0.07%) ⬇️
appsec-node-serialize 43.37% <ø> (-0.09%) ⬇️
appsec-passport 47.89% <ø> (-0.09%) ⬇️
appsec-postgres 50.90% <ø> (-0.08%) ⬇️
appsec-sourcing 42.72% <ø> (-0.09%) ⬇️
appsec-template 43.54% <ø> (-0.09%) ⬇️
appsec-ubuntu 58.83% <ø> (-0.07%) ⬇️
appsec-windows 58.62% <ø> (-0.05%) ⬇️
instrumentations-instrumentation-bluebird 32.28% <ø> (-0.11%) ⬇️
instrumentations-instrumentation-body-parser 40.59% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-child_process 37.89% <ø> (-0.11%) ⬇️
instrumentations-instrumentation-cookie-parser 34.33% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-express 34.67% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-express-mongo-sanitize 34.46% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-express-session 40.21% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-fs 31.88% <ø> (-0.11%) ⬇️
instrumentations-instrumentation-generic-pool 29.76% <ø> (ø)
instrumentations-instrumentation-http 39.93% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-knex 32.28% <ø> (-0.11%) ⬇️
instrumentations-instrumentation-mongoose 33.46% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-multer 40.33% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-mysql2 38.38% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-passport 44.18% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-passport-http 43.85% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-passport-local 44.40% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-pg 37.79% <ø> (-0.11%) ⬇️
instrumentations-instrumentation-promise 32.21% <ø> (-0.11%) ⬇️
instrumentations-instrumentation-promise-js 32.21% <ø> (-0.11%) ⬇️
instrumentations-instrumentation-q 32.26% <ø> (-0.11%) ⬇️
instrumentations-instrumentation-url 32.18% <ø> (-0.11%) ⬇️
instrumentations-instrumentation-when 32.23% <ø> (-0.11%) ⬇️
llmobs-ai 41.42% <ø> (-0.10%) ⬇️
llmobs-anthropic 40.40% <ø> (-0.10%) ⬇️
llmobs-bedrock 39.32% <ø> (-0.09%) ⬇️
llmobs-google-genai 39.91% <ø> (-0.09%) ⬇️
llmobs-langchain 39.49% <ø> (-0.08%) ⬇️
llmobs-openai 44.23% <ø> (-0.09%) ⬇️
llmobs-vertex-ai 40.11% <ø> (-0.10%) ⬇️
platform-core 29.71% <ø> (ø)
platform-esbuild 32.89% <ø> (ø)
platform-instrumentations-misc 40.53% <ø> (ø)
platform-shimmer 36.14% <ø> (ø)
platform-unit-guardrails 31.27% <ø> (ø)
plugins-azure-event-hubs 24.02% <ø> (ø)
plugins-azure-service-bus 23.42% <ø> (ø)
plugins-bullmq 43.63% <ø> (-0.18%) ⬇️
plugins-cassandra 37.85% <ø> (-0.10%) ⬇️
plugins-cookie 25.08% <ø> (ø)
plugins-cookie-parser 24.87% <ø> (ø)
plugins-crypto 24.72% <ø> (ø)
plugins-dd-trace-api 38.43% <ø> (-0.11%) ⬇️
plugins-express-mongo-sanitize 25.04% <ø> (ø)
plugins-express-session 24.83% <ø> (ø)
plugins-fastify 42.36% <ø> (-0.10%) ⬇️
plugins-fetch 38.39% <ø> (-0.10%) ⬇️
plugins-fs 38.68% <ø> (-0.11%) ⬇️
plugins-generic-pool 24.06% <ø> (ø)
plugins-google-cloud-pubsub 45.51% <ø> (-0.09%) ⬇️
plugins-grpc 41.05% <ø> (-0.10%) ⬇️
plugins-handlebars 25.08% <ø> (ø)
plugins-hapi 40.22% <ø> (-0.10%) ⬇️
plugins-hono 40.49% <ø> (-0.10%) ⬇️
plugins-ioredis 38.49% <ø> (-0.11%) ⬇️
plugins-knex 24.80% <ø> (ø)
plugins-ldapjs 22.61% <ø> (ø)
plugins-light-my-request 24.48% <ø> (ø)
plugins-limitd-client 32.58% <ø> (-0.11%) ⬇️
plugins-lodash 24.13% <ø> (ø)
plugins-mariadb 39.59% <ø> (-0.10%) ⬇️
plugins-memcached 38.22% <ø> (-0.11%) ⬇️
plugins-microgateway-core 39.25% <ø> (-0.32%) ⬇️
plugins-moleculer 40.61% <ø> (-0.10%) ⬇️
plugins-mongodb 39.26% <ø> (-0.10%) ⬇️
plugins-mongodb-core 39.09% <ø> (-0.10%) ⬇️
plugins-mongoose 38.94% <ø> (-0.10%) ⬇️
plugins-multer 24.83% <ø> (ø)
plugins-mysql 39.23% <ø> (-0.11%) ⬇️
plugins-mysql2 39.33% <ø> (-0.10%) ⬇️
plugins-node-serialize 25.12% <ø> (ø)
plugins-opensearch 37.68% <ø> (-0.10%) ⬇️
plugins-passport-http 24.91% <ø> (ø)
plugins-postgres 35.73% <ø> (-0.09%) ⬇️
plugins-process 24.72% <ø> (ø)
plugins-pug 25.08% <ø> (ø)
plugins-redis 38.96% <ø> (-0.10%) ⬇️
plugins-router 43.12% <ø> (-0.10%) ⬇️
plugins-sequelize 23.66% <ø> (ø)
plugins-test-and-upstream-amqp10 38.56% <ø> (+0.04%) ⬆️
plugins-test-and-upstream-amqplib 43.90% <ø> (-0.10%) ⬇️
plugins-test-and-upstream-apollo 39.09% <ø> (-0.09%) ⬇️
plugins-test-and-upstream-avsc 38.82% <ø> (-0.11%) ⬇️
plugins-test-and-upstream-bunyan 33.89% <ø> (-0.11%) ⬇️
plugins-test-and-upstream-connect 40.90% <ø> (-0.10%) ⬇️
plugins-test-and-upstream-graphql 40.23% <ø> (-0.10%) ⬇️
plugins-test-and-upstream-koa 40.47% <ø> (-0.10%) ⬇️
plugins-test-and-upstream-protobufjs 39.06% <ø> (-0.11%) ⬇️
plugins-test-and-upstream-rhea 44.15% <ø> (-0.13%) ⬇️
plugins-undici 39.18% <ø> (-0.10%) ⬇️
plugins-url 24.72% <ø> (ø)
plugins-valkey 38.14% <ø> (-0.11%) ⬇️
plugins-vm 24.72% <ø> (ø)
plugins-winston 34.08% <ø> (-0.10%) ⬇️
plugins-ws 42.01% <ø> (-0.10%) ⬇️
profiling-macos 39.98% <ø> (-0.48%) ⬇️
profiling-ubuntu 40.11% <ø> (-0.10%) ⬇️
profiling-windows 41.70% <ø> (+0.26%) ⬆️
serverless-azure-functions-client 23.75% <ø> (ø)
serverless-azure-functions-eventhubs 23.75% <ø> (ø)
serverless-azure-functions-servicebus 23.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread .agents/skills/add-new-instrumentation/SKILL.md
@watson watson requested a review from pabloerhard February 18, 2026 16:44
Copy link
Copy Markdown
Contributor

@pabloerhard pabloerhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot merged commit 909261e into master Feb 18, 2026
1126 of 1133 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot deleted the watson/skills branch February 18, 2026 17:12
@wconti27
Copy link
Copy Markdown
Contributor

Hey, I would've expected a ping for the IDM team for this skill. Appreciate the effort in getting something out there, but the skill has some out of date code that we don't want to reinforce. For example, it uses traditional Shimmer based wrapping, which we would like to move away from in favor of Orchestrion wrapping.

@watson
Copy link
Copy Markdown
Collaborator Author

watson commented Feb 18, 2026

If you let me know what needs to be changed I'll happily update it, or if you think it's easier, I can approve a PR you create

@watson
Copy link
Copy Markdown
Collaborator Author

watson commented Feb 18, 2026

Maybe we should add IDM as a CODEOWNER for the folder as well then

@wconti27
Copy link
Copy Markdown
Contributor

If you let me know what needs to be changed I'll happily update it, or if you think it's easier, I can approve a PR you create

I have a skill that I have been developing for exactly this, i will open a PR for it and we can collaborate as needed on it.

@wconti27 wconti27 mentioned this pull request Feb 18, 2026
@wconti27
Copy link
Copy Markdown
Contributor

FYI: #7568. A bit more context, but I've been working on this skill for the last few weeks, it has served me well so far!

dd-octo-sts Bot pushed a commit that referenced this pull request Feb 19, 2026
chore: add add-new-instrumentation agent skill

Adds a shared skill guide for creating new dd-trace instrumentations
and plugins. The skill lives under `.agents/skills/` and is symlinked
into both `.claude/skills/` and `.cursor/skills/` so it's available
to all AI agents. Updates `.gitignore` to track the skill files while
continuing to exclude other Claude/Cursor settings.

Address review comments

Co-authored-by: thomas.watson <thomas.watson@datadoghq.com>
@dd-octo-sts dd-octo-sts Bot mentioned this pull request Feb 19, 2026
dd-octo-sts Bot pushed a commit that referenced this pull request Feb 20, 2026
chore: add add-new-instrumentation agent skill

Adds a shared skill guide for creating new dd-trace instrumentations
and plugins. The skill lives under `.agents/skills/` and is symlinked
into both `.claude/skills/` and `.cursor/skills/` so it's available
to all AI agents. Updates `.gitignore` to track the skill files while
continuing to exclude other Claude/Cursor settings.

Address review comments

Co-authored-by: thomas.watson <thomas.watson@datadoghq.com>
@dd-octo-sts dd-octo-sts Bot mentioned this pull request Feb 20, 2026
juan-fernandez pushed a commit that referenced this pull request Mar 5, 2026
chore: add add-new-instrumentation agent skill

Adds a shared skill guide for creating new dd-trace instrumentations
and plugins. The skill lives under `.agents/skills/` and is symlinked
into both `.claude/skills/` and `.cursor/skills/` so it's available
to all AI agents. Updates `.gitignore` to track the skill files while
continuing to exclude other Claude/Cursor settings.

Address review comments

Co-authored-by: thomas.watson <thomas.watson@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants