add codeowners validation and ensure teams for all tests#7595
add codeowners validation and ensure teams for all tests#7595
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7595 +/- ##
=======================================
Coverage 80.32% 80.32%
=======================================
Files 733 734 +1
Lines 31546 31602 +56
=======================================
+ Hits 25338 25384 +46
- Misses 6208 6218 +10 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Overall package sizeSelf size: 4.79 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 2.0.6 | 81.92 kB | 816.75 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
This comment has been minimized.
This comment has been minimized.
juan-fernandez
left a comment
juan-fernandez
left a comment
There was a problem hiding this comment.
looks good from test optimization's perspective
sabrenner
left a comment
sabrenner
left a comment
There was a problem hiding this comment.
lgtm for ml-observability
| /packages/datadog-plugin-openai/ @DataDog/ml-observability | ||
| /packages/dd-trace/src/llmobs/ @DataDog/ml-observability | ||
| /packages/dd-trace/test/llmobs/ @DataDog/ml-observability | ||
| /packages/dd-trace/test/plugins/util/llm.spec.js @DataDog/ml-observability |
There was a problem hiding this comment.
this made me realize that the source file isn't covered in codeowners for this test file, if you wanna add it in, otherwise i'll do it as a driveby in whatever my next pr is 😄
There was a problem hiding this comment.
Yeah there are still a lot of files that are missing coverage. We should eventually expand the check to all files. In the meantime it's more of a best effort.
5 participants
What does this PR do?
Add CODEOWNERS validation and ensure teams for all tests.
Motivation
Right now a lot of files are not covered by CODEOWNERS and fallback to dd-trace-js. Instead, every file should have a team.
Additional Notes
For now the check is limited to test files as the main goal is to ensure Test Optimization can properly identify the owner of a test, but ideally every file would have an owner even outside of tests eventually.