Skip to content

refactor(iast): prefer optional chaining over guard expressions #7621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CarlesDD merged 1 commit into from
Feb 26, 2026
Merged

refactor(iast): prefer optional chaining over guard expressions #7621

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/dd-trace/src/appsec/iast/analyzers/cookie-analyzer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ class CookieAnalyzer extends Analyzer {
}

_checkOCE (context, value) {
if (value && value.location) {
if (value?.location) {
return true
}
return super._checkOCE(context, value)
Expand Down
2 changes: 1 addition & 1 deletion packages/dd-trace/src/appsec/iast/analyzers/ssrf-analyzer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ class SSRFAnalyzer extends InjectionAnalyzer {
this.addSub('apm:http:client:request:start', ({ args }) => {
if (typeof args.originalUrl === 'string') {
this.analyze(args.originalUrl)
} else if (args.options && args.options.host) {
} else if (args.options?.host) {
this.analyze(args.options.host)
}
})
Expand Down
2 changes: 1 addition & 1 deletion packages/dd-trace/src/appsec/iast/analyzers/unvalidated-redirect-analyzer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ class UnvalidatedRedirectAnalyzer extends InjectionAnalyzer {
}

isLocationHeader (name) {
return name && name.trim().toLowerCase() === 'location'
return name?.trim().toLowerCase() === 'location'
}

_isVulnerable (value, iastContext) {
Expand Down
2 changes: 1 addition & 1 deletion ...rabilities-formatter/evidence-redaction/sensitive-analyzers/command-sensitive-analyzer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ module.exports = function extractSensitiveRanges (evidence) {
pattern.lastIndex = 0

const regexResult = pattern.exec(evidence.value)
if (regexResult && regexResult.length > 1) {
if (regexResult?.length > 1) {
const start = regexResult.index + (regexResult[0].length - regexResult[1].length)
const end = start + regexResult[1].length
return [{ start, end }]
Expand Down
Loading