Skip to content

fix(runtime_metrics): fix non-native runtime.node.heap tags#7628

Merged
BridgeAR merged 2 commits intomasterfrom
BridgeAR/2025-02-26-fix-7555
Feb 27, 2026
Merged

fix(runtime_metrics): fix non-native runtime.node.heap tags#7628
BridgeAR merged 2 commits intomasterfrom
BridgeAR/2025-02-26-fix-7555

Conversation

@BridgeAR
Copy link
Copy Markdown
Member

The fallback when the runtime metrics is not using the native module would send the wrong tags. This happens more frequent due to having optional dependencies now.

Fixes: #7555

@BridgeAR BridgeAR requested a review from a team as a code owner February 26, 2026 13:37
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.24%. Comparing base (3913137) to head (bcb29c3).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7628   +/-   ##
=======================================
  Coverage   80.24%   80.24%           
=======================================
  Files         733      733           
  Lines       31662    31662           
=======================================
  Hits        25408    25408           
  Misses       6254     6254           
Flag Coverage Δ
aiguard-macos 38.94% <ø> (-0.10%) ⬇️
aiguard-ubuntu 39.05% <ø> (-0.10%) ⬇️
aiguard-windows 38.79% <ø> (-0.10%) ⬇️
apm-capabilities-tracing-macos 48.51% <100.00%> (+0.04%) ⬆️
apm-capabilities-tracing-ubuntu 48.54% <100.00%> (ø)
apm-capabilities-tracing-windows 48.28% <100.00%> (+0.04%) ⬆️
apm-integrations-child-process 38.52% <ø> (-0.10%) ⬇️
apm-integrations-couchbase-18 37.30% <ø> (-0.24%) ⬇️
apm-integrations-couchbase-eol 37.92% <ø> (-0.10%) ⬇️
apm-integrations-oracledb 37.75% <ø> (-0.10%) ⬇️
appsec-express 55.38% <ø> (-0.07%) ⬇️
appsec-fastify 51.69% <ø> (-0.07%) ⬇️
appsec-graphql 51.87% <ø> (-0.07%) ⬇️
appsec-kafka 44.35% <ø> (-0.08%) ⬇️
appsec-ldapjs 44.04% <ø> (-0.08%) ⬇️
appsec-lodash 43.70% <ø> (-0.08%) ⬇️
appsec-macos 58.38% <ø> (-0.07%) ⬇️
appsec-mongodb-core 48.86% <ø> (-0.08%) ⬇️
appsec-mongoose 49.54% <ø> (-0.08%) ⬇️
appsec-mysql 50.90% <ø> (-0.07%) ⬇️
appsec-node-serialize 43.21% <ø> (-0.08%) ⬇️
appsec-passport 47.67% <ø> (-0.09%) ⬇️
appsec-postgres 50.64% <ø> (-0.07%) ⬇️
appsec-sourcing 42.61% <ø> (-0.08%) ⬇️
appsec-template 43.38% <ø> (-0.08%) ⬇️
appsec-ubuntu 58.46% <ø> (?)
appsec-windows 58.22% <ø> (-0.07%) ⬇️
instrumentations-instrumentation-bluebird 32.31% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-body-parser 40.49% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-child_process 37.84% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-cookie-parser 34.31% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-express 34.64% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-express-mongo-sanitize 34.44% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-express-session 40.12% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-fs 31.92% <ø> (-0.11%) ⬇️
instrumentations-instrumentation-generic-pool 29.73% <ø> (ø)
instrumentations-instrumentation-http 39.84% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-knex 32.31% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-mongoose 33.45% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-multer 40.24% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-mysql2 38.31% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-passport 44.03% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-passport-http 43.70% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-passport-local 44.24% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-pg 37.73% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-promise 32.24% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-promise-js 32.25% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-q 32.29% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-url 32.21% <ø> (-0.11%) ⬇️
instrumentations-instrumentation-when 32.26% <ø> (-0.10%) ⬇️
llmobs-ai 41.30% <ø> (-0.10%) ⬇️
llmobs-anthropic 40.31% <ø> (-0.09%) ⬇️
llmobs-bedrock 39.26% <ø> (-0.09%) ⬇️
llmobs-google-genai 39.84% <ø> (-0.09%) ⬇️
llmobs-langchain 39.75% <ø> (-0.08%) ⬇️
llmobs-openai 44.08% <ø> (-0.09%) ⬇️
llmobs-vertex-ai 40.03% <ø> (-0.09%) ⬇️
platform-core 31.53% <ø> (ø)
platform-esbuild 34.48% <ø> (ø)
platform-instrumentations-misc 43.70% <ø> (ø)
platform-shimmer 37.63% <ø> (ø)
platform-unit-guardrails 32.95% <ø> (ø)
plugins-azure-event-hubs 25.59% <ø> (ø)
plugins-azure-service-bus 24.96% <ø> (ø)
plugins-bullmq 43.65% <ø> (-0.10%) ⬇️
plugins-cassandra 37.79% <ø> (-0.10%) ⬇️
plugins-cookie 26.65% <ø> (ø)
plugins-cookie-parser 26.44% <ø> (ø)
plugins-crypto 26.79% <ø> (ø)
plugins-dd-trace-api 38.37% <ø> (-0.10%) ⬇️
plugins-express-mongo-sanitize 26.59% <ø> (ø)
plugins-express-session 26.40% <ø> (ø)
plugins-fastify 42.24% <ø> (-0.09%) ⬇️
plugins-fetch 38.33% <ø> (-0.10%) ⬇️
plugins-fs 38.62% <ø> (-0.10%) ⬇️
plugins-generic-pool 25.63% <ø> (ø)
plugins-google-cloud-pubsub 45.38% <ø> (-0.09%) ⬇️
plugins-grpc 40.94% <ø> (-0.09%) ⬇️
plugins-handlebars 26.63% <ø> (ø)
plugins-hapi 40.13% <ø> (-0.10%) ⬇️
plugins-hono 40.39% <ø> (-0.10%) ⬇️
plugins-ioredis 38.43% <ø> (-0.10%) ⬇️
plugins-knex 26.28% <ø> (ø)
plugins-ldapjs 24.13% <ø> (ø)
plugins-light-my-request 26.00% <ø> (ø)
plugins-limitd-client 32.60% <ø> (-0.10%) ⬇️
plugins-lodash 25.72% <ø> (ø)
plugins-mariadb 39.49% <ø> (-0.10%) ⬇️
plugins-memcached 38.17% <ø> (-0.10%) ⬇️
plugins-microgateway-core 39.17% <ø> (-0.10%) ⬇️
plugins-moleculer 40.51% <ø> (-0.10%) ⬇️
plugins-mongodb 39.20% <ø> (-0.10%) ⬇️
plugins-mongodb-core 39.03% <ø> (-0.10%) ⬇️
plugins-mongoose 38.86% <ø> (-0.10%) ⬇️
plugins-multer 26.40% <ø> (ø)
plugins-mysql 39.17% <ø> (-0.10%) ⬇️
plugins-mysql2 39.27% <ø> (-0.10%) ⬇️
plugins-node-serialize 26.69% <ø> (ø)
plugins-opensearch 37.62% <ø> (-0.10%) ⬇️
plugins-passport-http 26.45% <ø> (ø)
plugins-postgres 35.73% <ø> (-0.15%) ⬇️
plugins-process 26.79% <ø> (ø)
plugins-pug 26.65% <ø> (ø)
plugins-redis 38.90% <ø> (-0.10%) ⬇️
plugins-router 42.97% <ø> (-0.10%) ⬇️
plugins-sequelize 25.23% <ø> (ø)
plugins-test-and-upstream-amqp10 38.35% <ø> (-0.10%) ⬇️
plugins-test-and-upstream-amqplib 43.83% <ø> (-0.10%) ⬇️
plugins-test-and-upstream-apollo 39.03% <ø> (-0.09%) ⬇️
plugins-test-and-upstream-avsc 38.71% <ø> (-0.10%) ⬇️
plugins-test-and-upstream-bunyan 33.88% <ø> (-0.10%) ⬇️
plugins-test-and-upstream-connect 40.79% <ø> (-0.10%) ⬇️
plugins-test-and-upstream-graphql 40.14% <ø> (-0.10%) ⬇️
plugins-test-and-upstream-koa 40.37% <ø> (-0.10%) ⬇️
plugins-test-and-upstream-protobufjs 38.94% <ø> (-0.10%) ⬇️
plugins-test-and-upstream-rhea 44.06% <ø> (-0.10%) ⬇️
plugins-undici 39.11% <ø> (-0.09%) ⬇️
plugins-url 26.79% <ø> (ø)
plugins-valkey 38.06% <ø> (-0.13%) ⬇️
plugins-vm 26.79% <ø> (ø)
plugins-winston 34.07% <ø> (-0.10%) ⬇️
plugins-ws 41.89% <ø> (-0.10%) ⬇️
profiling-macos 39.84% <ø> (-0.10%) ⬇️
profiling-ubuntu 39.96% <ø> (-0.10%) ⬇️
profiling-windows 41.17% <ø> (-0.10%) ⬇️
serverless-azure-functions-client 25.31% <ø> (ø)
serverless-azure-functions-eventhubs 25.31% <ø> (ø)
serverless-azure-functions-servicebus 25.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 26, 2026

Overall package size

Self size: 4.84 MB
Deduped: 5.69 MB
No deduping: 5.69 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 2.0.6 | 81.92 kB | 816.75 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

rochdev
rochdev previously approved these changes Feb 26, 2026
The fallback when the runtime metrics is not using the native
module would send the wrong tags. This happens more frequent due
to having optional dependencies now.

Fixes: #7555
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Feb 26, 2026

Benchmarks

Benchmark execution time: 2026-02-27 07:57:39

Comparing candidate commit bcb29c3 in PR branch BridgeAR/2025-02-26-fix-7555 with baseline commit 3913137 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 230 metrics, 30 unstable metrics.

@BridgeAR BridgeAR enabled auto-merge (squash) February 26, 2026 13:52
@BridgeAR BridgeAR merged commit ab05db8 into master Feb 27, 2026
824 of 826 checks passed
@BridgeAR BridgeAR deleted the BridgeAR/2025-02-26-fix-7555 branch February 27, 2026 08:27
dd-octo-sts Bot pushed a commit that referenced this pull request Feb 27, 2026
The fallback when the runtime metrics is not using the native
module would send the wrong tags. This happens more frequent due
to having optional dependencies now.

Fixes: #7555
@dd-octo-sts dd-octo-sts Bot mentioned this pull request Feb 27, 2026
juan-fernandez pushed a commit that referenced this pull request Mar 5, 2026
The fallback when the runtime metrics is not using the native
module would send the wrong tags. This happens more frequent due
to having optional dependencies now.

Fixes: #7555
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: runtime.node.heap.*by.space metric tag changed from heap_space to space

2 participants