feat(bundler): experimental webpack bundling support#7647
Merged
Conversation
tlhunter
added
semver-minor
bundler
AI Generated
Contributor
Overall package sizeSelf size: 5.05 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.0.0 | 81.15 kB | 815.98 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #7647 +/- ##
==========================================
- Coverage 80.46% 74.61% -5.85%
==========================================
Files 749 768 +19
Lines 32487 35661 +3174
==========================================
+ Hits 26140 26610 +470
- Misses 6347 9051 +2704
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tlhunter
force-pushed
the
tlhunter/webpack
branch
from
8f948e7 to
fec13fb
Compare
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: 41905e7 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
tlhunter
force-pushed
the
tlhunter/webpack
branch
2 times, most recently
from
0715b50 to
33857e5
Compare
tlhunter
commented
Mar 6, 2026
tlhunter
force-pushed
the
tlhunter/webpack
branch
2 times, most recently
from
5333d4d to
a76a9a2
Compare
tlhunter
changed the title
watson
reviewed
Mar 10, 2026
tlhunter
force-pushed
the
tlhunter/webpack
branch
from
a63830e to
58cbf51
Compare
Member
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 58cbf51855
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
tlhunter
force-pushed
the
tlhunter/webpack
branch
from
58cbf51 to
8bf9e1a
Compare
Member
Author
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8bf9e1ab24
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
tlhunter
force-pushed
the
tlhunter/webpack
branch
from
8bf9e1a to
8c38ab5
Compare
IlyasShabi
reviewed
Mar 12, 2026
Comment on lines
37
to
+40
| "test:esbuild": "mocha packages/datadog-esbuild/test/**/*.spec.js", | ||
| "test:esbuild:ci": "nyc -- npm run test:esbuild", | ||
| "test:webpack": "mocha packages/datadog-webpack/test/**/*.spec.js", | ||
| "test:webpack:ci": "nyc -- npm run test:webpack", |
Contributor
There was a problem hiding this comment.
Is it possible to have one script for all bundlers?
Member
Author
There was a problem hiding this comment.
I tried that approach but it was pretty messy. There's a tool called unplugin we can use but I wasn't able to get the code any cleaner.
IlyasShabi
reviewed
Mar 12, 2026
IlyasShabi
reviewed
Mar 12, 2026
tlhunter
force-pushed
the
tlhunter/webpack
branch
from
8c38ab5 to
db23a6f
Compare
Contributor
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: db23a6fc1f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| throw e | ||
| } | ||
|
|
||
| if (isESMFile(normalizedResource, pkgJson, packageJson)) { |
There was a problem hiding this comment.
normalizedResource (forward-slash path) is passed into isESMFile, but that helper splits on path.sep. On Windows this means the path never splits as intended, so ESM detection falls back to unrelated package.json lookups (often the app root) and can misclassify ESM files as CJS. In webpack bundles on Windows, this can cause the loader to be injected into ESM modules and break instrumentation/runtime behavior. Use the original platform path for isESMFile (or normalize inside that helper consistently).
Useful? React with 👍 / 👎.
Contributor
|
@CarlesDD IIRC we had an issue with IAST and esbuild that was fixed by Ugaitz, could you please check if IAST will continue to work with webpack plugin please |
Member
Author
|
I'm fine with sussing out if the IAST issue still exists after this gets merged. It's marked as experimental after all. |
tlhunter
force-pushed
the
tlhunter/webpack
branch
from
db23a6f to
c80d589
Compare
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
tlhunter
force-pushed
the
tlhunter/webpack
branch
from
c80d589 to
41905e7
Compare
CarlesDD
approved these changes
Mar 26, 2026
dd-octo-sts Bot
pushed a commit
that referenced
this pull request
Mar 27, 2026
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Merged
litianningdatadog
pushed a commit
that referenced
this pull request
Mar 30, 2026
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
juan-fernandez
pushed a commit
that referenced
this pull request
Apr 1, 2026
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example Usage: