fix(bullmq): trace context injection and orchestrion file extensions#7669
Merged
fix(bullmq): trace context injection and orchestrion file extensions#7669
Conversation
Importing a JSON file without its extension is non-standard and breaks with bundlers like nx/rollup. Convert to a JS module for compatibility. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Overall package sizeSelf size: 4.89 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 2.0.6 | 81.92 kB | 816.75 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7669 +/- ##
=======================================
Coverage 80.29% 80.30%
=======================================
Files 738 739 +1
Lines 31897 31926 +29
=======================================
+ Hits 25611 25637 +26
- Misses 6286 6289 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Delete the telemetry metadata from job opts after extracting the trace and DSM context in the consumer. This prevents internal trace data from leaking to user code, which can cause issues with strict schema validation (e.g. zod). Fixes #7641 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
wconti27
changed the title
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Store dd-trace context under the _datadog key within the telemetry metadata JSON object instead of using the entire metadata field. This preserves any other telemetry metadata that may exist. On the consumer side, only the _datadog key is extracted and removed, leaving the rest of the metadata intact. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
crysmags
approved these changes
Mar 4, 2026
dd-octo-sts Bot
pushed a commit
that referenced
this pull request
Mar 5, 2026
…7669) move bullmq trace context into opts.telemetry.metadata json string. delete propagated job context after consumption. fix bullmq orchestrion file extension
Merged
juan-fernandez
pushed a commit
that referenced
this pull request
Mar 5, 2026
…7669) move bullmq trace context into opts.telemetry.metadata json string. delete propagated job context after consumption. fix bullmq orchestrion file extension
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
opts.telemetry.metadatafield for correct context propagation bullmq trace context wrong location.jsonextension is non-standard and breaks with bundlers like nx/rollup. Converts the rewriter instrumentation config from JSON to a JS module for compatibility. Fixes this comment: bullmq .json extensions problem