Skip to content

[test optimization] Propagate test span context during vitest test execution#7882

Merged
juan-fernandez merged 2 commits intomasterfrom
juan-fernandez/fix-vitest-test-span-context
Mar 30, 2026
Merged

[test optimization] Propagate test span context during vitest test execution#7882
juan-fernandez merged 2 commits intomasterfrom
juan-fernandez/fix-vitest-test-span-context

Conversation

@juan-fernandez
Copy link
Copy Markdown
Collaborator

Summary

  • Wrap vitest test functions using @vitest/runner's getFn/setFn to run inside the test span's AsyncLocalStorage context via a new ci:vitest:test:fn channel (mirroring Jest's testFnCh pattern)
  • Wrap beforeEach/afterEach hooks by walking the suite hierarchy and using getHooks (vitest 4+ WeakMap) or suite.hooks (older versions)
  • Capture runner functions via addHook for @vitest/runner (vitest <4) and findExportByName on bundled chunks (vitest 4+)

Without this fix, testStartCh.runStores(ctx, () => {}) only activated the store during the empty callback — the actual test function and hooks ran after it returned, so HTTP spans became orphaned root spans and tracer.scope().active() returned null.

Fixes #7874

Test plan

  • Added integration test that verifies HTTP spans from test functions are children of the test span (trace_id + parent_id)
  • Added integration test that verifies custom tags set via tracer.scope().active() appear on the test span
  • Added integration test that verifies HTTP spans from beforeEach/afterEach hooks are children of the test span
  • Verified all 3 assertions fail on master and pass with the fix
  • Verified on both vitest@1.6.0 and vitest@latest
  • Verified existing vitest integration tests still pass

🤖 Generated with Claude Code

…ecution

Wrap vitest test functions and beforeEach/afterEach hooks to run inside
the test span's AsyncLocalStorage context, ensuring HTTP requests and
custom tags are properly linked to the test span.

Fixes #7874

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
@juan-fernandez juan-fernandez requested a review from a team as a code owner March 30, 2026 10:58
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 30, 2026

Overall package size

Self size: 5.06 MB
Deduped: 5.9 MB
No deduping: 5.9 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.0.0 | 81.15 kB | 815.98 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@datadog-datadog-prod-us1-2
Copy link
Copy Markdown

datadog-datadog-prod-us1-2 Bot commented Mar 30, 2026

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage (details)
Patch Coverage: 10.91%
Overall Coverage: 68.96% (-4.58%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: e68e937 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

@juan-fernandez juan-fernandez changed the title fix(ci-visibility): propagate test span context during vitest test execution [test optimization] Propagate test span context during vitest test execution Mar 30, 2026
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Mar 30, 2026

Benchmarks

Benchmark execution time: 2026-03-30 11:50:13

Comparing candidate commit e68e937 in PR branch juan-fernandez/fix-vitest-test-span-context with baseline commit 1733e97 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 226 metrics, 34 unstable metrics.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 30, 2026

Codecov Report

❌ Patch coverage is 10.90909% with 49 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.51%. Comparing base (1733e97) to head (e68e937).
⚠️ Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
packages/datadog-instrumentations/src/vitest.js 11.32% 47 Missing ⚠️
packages/datadog-plugin-vitest/src/index.js 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7882      +/-   ##
==========================================
- Coverage   74.62%   74.51%   -0.11%     
==========================================
  Files         768      768              
  Lines       35673    35728      +55     
==========================================
+ Hits        26620    26624       +4     
- Misses       9053     9104      +51     
Flag Coverage Δ
aiguard-macos 39.23% <ø> (-0.10%) ⬇️
aiguard-ubuntu 39.35% <ø> (-0.10%) ⬇️
aiguard-windows 39.02% <ø> (-0.10%) ⬇️
apm-capabilities-tracing-macos 49.08% <0.00%> (-0.02%) ⬇️
apm-capabilities-tracing-ubuntu 49.00% <0.00%> (-0.01%) ⬇️
apm-capabilities-tracing-windows 48.74% <0.00%> (-0.13%) ⬇️
apm-integrations-child-process 38.56% <ø> (-0.10%) ⬇️
apm-integrations-couchbase-18 37.36% <ø> (-0.10%) ⬇️
apm-integrations-couchbase-eol 37.85% <ø> (-0.10%) ⬇️
apm-integrations-oracledb 37.69% <ø> (-0.10%) ⬇️
appsec-express 55.16% <ø> (-0.10%) ⬇️
appsec-fastify 51.52% <ø> (-0.07%) ⬇️
appsec-graphql 51.69% <ø> (-0.07%) ⬇️
appsec-kafka 44.32% <ø> (-0.08%) ⬇️
appsec-ldapjs 43.94% <ø> (-0.08%) ⬇️
appsec-lodash 43.54% <ø> (-0.08%) ⬇️
appsec-macos 58.18% <ø> (-0.07%) ⬇️
appsec-mongodb-core 48.70% <ø> (-0.09%) ⬇️
appsec-mongoose 49.36% <ø> (-0.08%) ⬇️
appsec-mysql 50.79% <ø> (-0.07%) ⬇️
appsec-node-serialize 43.12% <ø> (-0.08%) ⬇️
appsec-passport 47.55% <ø> (-0.09%) ⬇️
appsec-postgres 50.53% <ø> (-0.05%) ⬇️
appsec-sourcing 42.37% <ø> (-0.08%) ⬇️
appsec-stripe 44.55% <ø> (-0.08%) ⬇️
appsec-template 43.29% <ø> (-0.08%) ⬇️
appsec-ubuntu 58.26% <ø> (-0.07%) ⬇️
appsec-windows 58.01% <ø> (-0.07%) ⬇️
instrumentations-instrumentation-bluebird 32.20% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-body-parser 40.46% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-child_process 37.90% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-cookie-parser 34.23% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-express 34.55% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-express-mongo-sanitize 34.36% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-express-session 40.10% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-fs 31.89% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-generic-pool 29.45% <ø> (ø)
instrumentations-instrumentation-http 39.81% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-knex 32.27% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-mongoose 33.39% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-multer 40.21% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-mysql2 38.24% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-passport 43.98% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-passport-http 43.66% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-passport-local 44.19% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-pg 37.68% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-promise 32.13% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-promise-js 32.14% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-q 32.18% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-url 32.10% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-when 32.15% <ø> (-0.10%) ⬇️
llmobs-ai 42.37% <ø> (-0.10%) ⬇️
llmobs-anthropic 40.39% <ø> (-0.09%) ⬇️
llmobs-bedrock 39.18% <ø> (-0.08%) ⬇️
llmobs-google-genai 39.72% <ø> (-0.09%) ⬇️
llmobs-langchain 40.08% <ø> (-0.19%) ⬇️
llmobs-openai 43.90% <ø> (-0.09%) ⬇️
llmobs-vertex-ai 39.97% <ø> (-0.09%) ⬇️
platform-core 31.47% <ø> (ø)
platform-esbuild 34.42% <ø> (ø)
platform-instrumentations-misc 48.41% <ø> (ø)
platform-shimmer 37.56% <ø> (ø)
platform-unit-guardrails 32.89% <ø> (ø)
platform-webpack 20.01% <11.32%> (-0.03%) ⬇️
plugins-azure-durable-functions 25.74% <ø> (ø)
plugins-azure-event-hubs 25.90% <ø> (ø)
plugins-azure-service-bus 25.26% <ø> (ø)
plugins-bullmq 44.40% <ø> (-0.10%) ⬇️
plugins-cassandra 37.86% <ø> (-0.10%) ⬇️
plugins-cookie 26.96% <ø> (ø)
plugins-cookie-parser 26.75% <ø> (ø)
plugins-crypto 26.73% <ø> (ø)
plugins-dd-trace-api 38.26% <ø> (-0.10%) ⬇️
plugins-express-mongo-sanitize 26.89% <ø> (ø)
plugins-express-session 26.70% <ø> (ø)
plugins-fastify 42.18% <ø> (-0.09%) ⬇️
plugins-fetch 38.35% <ø> (-0.10%) ⬇️
plugins-fs 38.59% <ø> (-0.10%) ⬇️
plugins-generic-pool 25.94% <ø> (ø)
plugins-google-cloud-pubsub 45.49% <ø> (-0.09%) ⬇️
plugins-grpc 40.85% <ø> (-0.09%) ⬇️
plugins-handlebars 26.94% <ø> (ø)
plugins-hapi 40.10% <ø> (-0.23%) ⬇️
plugins-hono 40.43% <ø> (-0.10%) ⬇️
plugins-ioredis 38.40% <ø> (-0.10%) ⬇️
plugins-knex 26.57% <ø> (ø)
plugins-langgraph 38.45% <ø> (-0.10%) ⬇️
plugins-ldapjs 24.43% <ø> (ø)
plugins-light-my-request 26.30% <ø> (ø)
plugins-limitd-client 32.48% <ø> (-0.10%) ⬇️
plugins-lodash 26.03% <ø> (ø)
plugins-mariadb 39.44% <ø> (-0.10%) ⬇️
plugins-memcached 38.14% <ø> (-0.10%) ⬇️
plugins-microgateway-core 39.17% <ø> (-0.10%) ⬇️
plugins-moleculer 40.46% <ø> (-0.09%) ⬇️
plugins-mongodb 39.11% <ø> (-0.09%) ⬇️
plugins-mongodb-core 38.95% <ø> (-0.10%) ⬇️
plugins-mongoose 38.83% <ø> (-0.09%) ⬇️
plugins-multer 26.70% <ø> (ø)
plugins-mysql 39.14% <ø> (-0.10%) ⬇️
plugins-mysql2 39.23% <ø> (-0.10%) ⬇️
plugins-node-serialize 27.00% <ø> (ø)
plugins-opensearch 37.59% <ø> (-0.10%) ⬇️
plugins-passport-http 26.76% <ø> (ø)
plugins-postgres 35.53% <ø> (-0.09%) ⬇️
plugins-process 26.73% <ø> (ø)
plugins-pug 26.96% <ø> (ø)
plugins-redis 38.86% <ø> (-0.10%) ⬇️
plugins-router 43.03% <ø> (-0.23%) ⬇️
plugins-sequelize 25.55% <ø> (ø)
plugins-test-and-upstream-amqp10 38.45% <ø> (-0.10%) ⬇️
plugins-test-and-upstream-amqplib 44.15% <ø> (-0.11%) ⬇️
plugins-test-and-upstream-apollo 39.08% <ø> (-0.09%) ⬇️
plugins-test-and-upstream-avsc 38.52% <ø> (-0.10%) ⬇️
plugins-test-and-upstream-bunyan 33.80% <ø> (-0.10%) ⬇️
plugins-test-and-upstream-connect 40.75% <ø> (-0.10%) ⬇️
plugins-test-and-upstream-graphql 40.10% <ø> (-0.10%) ⬇️
plugins-test-and-upstream-koa 40.34% <ø> (-0.10%) ⬇️
plugins-test-and-upstream-protobufjs 38.75% <ø> (-0.10%) ⬇️
plugins-test-and-upstream-rhea 44.16% <ø> (-0.13%) ⬇️
plugins-undici 39.07% <ø> (-0.09%) ⬇️
plugins-url 26.73% <ø> (ø)
plugins-valkey 38.11% <ø> (-0.10%) ⬇️
plugins-vm 26.73% <ø> (ø)
plugins-winston 33.99% <ø> (-0.10%) ⬇️
plugins-ws 41.93% <ø> (-0.10%) ⬇️
profiling-macos 40.47% <ø> (-0.10%) ⬇️
profiling-ubuntu 40.59% <ø> (-0.10%) ⬇️
profiling-windows 42.15% <ø> (-0.10%) ⬇️
serverless-azure-functions-client 25.62% <ø> (ø)
serverless-azure-functions-eventhubs 25.62% <ø> (ø)
serverless-azure-functions-servicebus 25.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…ion test

Verify that HTTP spans from vitest's beforeEach cleanup pattern (returning
a function from beforeEach) are also linked as children of the test span.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
@juan-fernandez juan-fernandez force-pushed the juan-fernandez/fix-vitest-test-span-context branch from f8dece7 to e68e937 Compare March 30, 2026 11:40
@juan-fernandez juan-fernandez merged commit f9d26d6 into master Mar 30, 2026
788 checks passed
@juan-fernandez juan-fernandez deleted the juan-fernandez/fix-vitest-test-span-context branch March 30, 2026 13:59
dd-octo-sts Bot pushed a commit that referenced this pull request Mar 31, 2026
@dd-octo-sts dd-octo-sts Bot mentioned this pull request Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: Vitest test span context not propagated to HTTP requests during test execution

2 participants