Set JS-specific injection package size ratchet#7907
Merged
Conversation
Contributor
Overall package sizeSelf size: 5.07 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.0.0 | 81.15 kB | 815.98 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: ffe2fd9 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7907 +/- ##
==========================================
- Coverage 74.35% 74.33% -0.02%
==========================================
Files 768 768
Lines 35855 35863 +8
==========================================
- Hits 26660 26659 -1
- Misses 9195 9204 +9 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
dd-trace-rb is two blocks down 👉 |
Merged
juan-fernandez
pushed a commit
that referenced
this pull request
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Introduce language-specific thresholds for the ratchet through one pipeline overrides
Motivation
Due to a change PHP-side libdatadog was bumped to v29. This version bump caused PHP images to blow past their previous limit.
Simultaneously, changes to the
datadog-packagebinary were picked up. Notably thegithub.com/klauspost/compress/zstddependency was bumped from 1.17.4 to 1.18.1. This bump included in 1.17.5 a default value change for the compression context size, downscaled from 32MB to 8MB (fixing compatibility with browsers like Chrome), causing drastic changes in compression results.Unbeknownst to the second change, PHP therefore updated the global limits, attributing the size change to the libdatadog bump (which was true, but not for the whole of it):
This allowed a change to slip through to other languages, where the new
datadog-packagebinary caused regressions in package size without change to the inputs. Due to the wildly differing sizes of packages across languages the regression is silent, rendering the size threshold ratchet moot.To combat such silently creeping regressions, this PR introduces language-specific thresholds for the ratchet.
Additional Notes
datadog-packagewas fixed in https://github.com/DataDog/datadog-packages/pull/64 which may take some time to trickle down.