feat(PDO): correct a bug on prepared statement regarding DBM correlation #3545
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem
DBM correlation was broken for PDO prepared statements. The traceparent SQL comment which DBM uses to correlate database queries with APM traces contained a span_id that didn't match the span representing the actual query execution.
Root Cause
When using prepared statements (PDO::prepare() + PDOStatement::execute()):
This prevented DBM from properly correlating database queries with their corresponding APM spans.
Solution
Following the RFC we now use SERVICE mode (DBM_PROPAGATION_SERVICE) for prepared statements instead of FULL mode.