Use php_log_err() rather than _php_error_log_ex() #3551
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I changed the signature of
_php_error_log()and removed_php_error_log_ex()on php-src@master and thinking of fully removing the exposed API as I can only find one other usage of it outside of dd-trace which is also always calling_php_error_log()with the same mode.So rather than doing effectively a function indirection call
php_log_err()directly (this is a compat macro on master, but my understanding is you support PHP 7.0 still)Reviewer checklist