Skip to content

Fixes the tag name for process tags #3709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dubloom merged 2 commits into from
Mar 19, 2026
Merged

Fixes the tag name for process tags #3709

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee0bfda
Fixes the tag name for process tags
dubloom Mar 18, 2026
d20193c
leftover
dubloom Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ext/serializer.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1614,7 +1614,7 @@ ddog_SpanBytes *ddtrace_serialize_span_to_rust_span(ddtrace_span_data *span, ddo
if (is_first_span) {
zend_string *process_tags = ddtrace_process_tags_get_serialized();
if (ZSTR_LEN(process_tags)) {
ddog_add_str_span_meta_zstr(rust_span, "_dd.process_tags", process_tags);
ddog_add_str_span_meta_zstr(rust_span, "_dd.tags.process", process_tags);
}
}

Expand Down
4 changes: 2 additions & 2 deletions tests/Integrations/Custom/Autoloaded/ProcessTagsWebTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@ public function testProcessTagsEnabledForWebSapi()
$rootSpan = $traces[0][0];

// Verify _dd.tags.process exists
$this->assertArrayHasKey('_dd.process_tags', $rootSpan['meta']);
$processTags = $rootSpan['meta']['_dd.process_tags'];
$this->assertArrayHasKey('_dd.tags.process', $rootSpan['meta']);
$processTags = $rootSpan['meta']['_dd.tags.process'];

// Parse the process tags
$tags = [];
Expand Down
4 changes: 2 additions & 2 deletions tests/ext/process_tags.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ $child_span->service = 'test_service';
$spans = dd_trace_serialize_closed_spans();

// Check if process tags are present
if (isset($spans[0]['meta']['_dd.process_tags'])) {
$processTags = $spans[0]['meta']['_dd.process_tags'];
if (isset($spans[0]['meta']['_dd.tags.process'])) {
$processTags = $spans[0]['meta']['_dd.tags.process'];
echo "Process tags present in root span: YES\n";
echo "Process tags: $processTags\n";

Expand Down
Loading