chore(profiler): span link independent from context provider#11303
Closed
chore(profiler): span link independent from context provider#11303
Conversation
We make sure that the span link mechanism in the profiler is independent from the context provider, as this can change with calls to `configure`. Instead we rely on the core event hub to emit an event when a span is activated so that the profiler can perform the linking with the corresponding thread.
Contributor
|
|
Datadog ReportBranch report: ✅ 0 Failed, 964 Passed, 322 Skipped, 21m 27.87s Total duration (16m 40.09s time saved) |
Contributor
Author
|
Related #12135 |
Contributor
Author
|
We can revisit if and when needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We make sure that the span link mechanism in the profiler is independent from the context provider, as this can change with calls to
configure. Instead we rely on the core event hub to emit an event when a span is activated so that the profiler can perform the linking with the corresponding thread.Checklist
Reviewer Checklist