Skip to content

refactor(core): move src/core to src/native#12065

Merged
mabdinur merged 4 commits intomainfrom
baptiste.foy/FA/core-to-native
Jan 24, 2025
Merged

refactor(core): move src/core to src/native#12065
mabdinur merged 4 commits intomainfrom
baptiste.foy/FA/core-to-native

Conversation

@BaptisteFoy
Copy link
Copy Markdown
Collaborator

@BaptisteFoy BaptisteFoy commented Jan 24, 2025

This PR depends on #12063.

Rename src/core to src/native. This is laying ground as a following PR will need to import native code in ddtrace.__init__.py. Without this change this would create a dependency loop between ddtrace & ddtrace.core through event_hub.py.

This PR only renames files, so a non-regression test is the only thing needed.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@BaptisteFoy BaptisteFoy added the changelog/no-changelog A changelog entry is not required for this PR. label Jan 24, 2025
@github-actions
Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

ddtrace/internal/native/__init__.py                                     @DataDog/apm-core-python
.github/workflows/rust-ci.yml                                           @DataDog/python-guild @DataDog/apm-core-python
ddtrace/internal/core/__init__.py                                       @DataDog/apm-core-python
ddtrace/internal/datastreams/processor.py                               @DataDog/apm-core-python
ddtrace/internal/processor/stats.py                                     @DataDog/apm-core-python
setup.py                                                                @DataDog/python-guild
tests/suitespec.yml                                                     @DataDog/python-guild @DataDog/apm-core-python
ddtrace/internal/native/_native.pyi                                     @DataDog/apm-core-python
src/native/Cargo.lock                                                   @DataDog/apm-core-python
src/native/Cargo.toml                                                   @DataDog/apm-core-python
src/native/ddsketch.rs                                                  @DataDog/apm-core-python
src/native/lib.rs                                                       @DataDog/apm-core-python

@BaptisteFoy BaptisteFoy force-pushed the baptiste.foy/FA/core-to-native branch from 4ef40c1 to 42a07eb Compare January 24, 2025 08:18
@BaptisteFoy BaptisteFoy marked this pull request as ready for review January 24, 2025 08:32
@BaptisteFoy BaptisteFoy requested review from a team as code owners January 24, 2025 08:32
@BaptisteFoy BaptisteFoy requested review from avara1986 and erikayasuda and removed request for a team January 24, 2025 08:32
@datadog-dd-trace-py-rkomorn
Copy link
Copy Markdown

datadog-dd-trace-py-rkomorn Bot commented Jan 24, 2025

Datadog Report

Branch report: baptiste.foy/FA/core-to-native
Commit report: 7148c15
Test service: dd-trace-py

✅ 0 Failed, 208 Passed, 1390 Skipped, 5m 9.33s Total duration (35m 18.41s time saved)

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Jan 24, 2025

Benchmarks

Benchmark execution time: 2025-01-24 14:59:59

Comparing candidate commit 7148c15 in PR branch baptiste.foy/FA/core-to-native with baseline commit cf83444 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

Base automatically changed from baptiste.foy/FA/bump-libdatadog to main January 24, 2025 14:09
@gitsync-ddbuild-stable7 gitsync-ddbuild-stable7 Bot requested review from a team as code owners January 24, 2025 14:09
@mabdinur mabdinur enabled auto-merge (squash) January 24, 2025 15:24
@mabdinur mabdinur merged commit 9e87349 into main Jan 24, 2025
@mabdinur mabdinur deleted the baptiste.foy/FA/core-to-native branch January 24, 2025 15:26
ZStriker19 pushed a commit that referenced this pull request Jan 30, 2025
This PR depends on #12063.

Rename src/core to src/native. This is laying ground as a [following
PR](#11839) will need to
import native code in `ddtrace.__init__.py`. Without this change this
would create a dependency loop between `ddtrace` & `ddtrace.core`
through `event_hub.py`.

This PR only renames files, so a non-regression test is the only thing
needed.

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog A changelog entry is not required for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants