Skip to content

ci(tracer): make serverless test unrequired#12121

Merged
christophe-papazian merged 2 commits intomainfrom
christophe-papazian/make_serverless_job_unrequired
Jan 28, 2025
Merged

ci(tracer): make serverless test unrequired#12121
christophe-papazian merged 2 commits intomainfrom
christophe-papazian/make_serverless_job_unrequired

Conversation

@christophe-papazian
Copy link
Copy Markdown
Contributor

@christophe-papazian christophe-papazian commented Jan 28, 2025

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@github-actions
Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

.gitlab/benchmarks.yml                                                  @DataDog/python-guild @DataDog/apm-core-python

@christophe-papazian christophe-papazian added changelog/no-changelog A changelog entry is not required for this PR. CI labels Jan 28, 2025
@christophe-papazian christophe-papazian enabled auto-merge (squash) January 28, 2025 13:05
@datadog-dd-trace-py-rkomorn
Copy link
Copy Markdown

datadog-dd-trace-py-rkomorn Bot commented Jan 28, 2025

Datadog Report

Branch report: christophe-papazian/make_serverless_job_unrequired
Commit report: 203e0d0
Test service: dd-trace-py

✅ 0 Failed, 130 Passed, 1468 Skipped, 5m 9.86s Total duration (35m 44.85s time saved)

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Jan 28, 2025

Benchmarks

Benchmark execution time: 2025-01-28 14:47:00

Comparing candidate commit 203e0d0 in PR branch christophe-papazian/make_serverless_job_unrequired with baseline commit 55767a7 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

@christophe-papazian christophe-papazian merged commit 16d5280 into main Jan 28, 2025
@christophe-papazian christophe-papazian deleted the christophe-papazian/make_serverless_job_unrequired branch January 28, 2025 14:48
ZStriker19 pushed a commit that referenced this pull request Jan 30, 2025
## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog A changelog entry is not required for this PR. CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants