Skip to content

chore(ci): skip non-linux OCI package creation [backport 2.17]#12158

Closed
github-actions[bot] wants to merge 1 commit into2.17from
backport-12036-to-2.17
Closed

chore(ci): skip non-linux OCI package creation [backport 2.17]#12158
github-actions[bot] wants to merge 1 commit into2.17from
backport-12036-to-2.17

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

Backport af9098c from #12036 to 2.17.

The shared pipeline is introducing support for windows OCI packages. This PR ensure dd-trace-py doesn't generate nonsensical packages. Windows support can be added later.

This was tested by using the WIP branch of one-pipeline

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

The shared pipeline is introducing support for windows OCI packages.
This PR ensure dd-trace-py doesn't generate nonsensical packages.
Windows support can be added later.

This was tested by using the WIP branch of one-pipeline

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

---------

Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com>
(cherry picked from commit af9098c)
@github-actions github-actions Bot added changelog/no-changelog A changelog entry is not required for this PR. CI labels Jan 30, 2025
@github-actions github-actions Bot requested review from a team as code owners January 30, 2025 10:35
@datadog-dd-trace-py-rkomorn
Copy link
Copy Markdown

Datadog Report

Branch report: backport-12036-to-2.17
Commit report: 516e3cb
Test service: dd-trace-py

✅ 0 Failed, 1286 Passed, 0 Skipped, 14m 3.32s Total Time

@randomanderson randomanderson enabled auto-merge (squash) January 30, 2025 10:56
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Jan 30, 2025

Benchmarks

Benchmark execution time: 2025-01-30 11:16:48

Comparing candidate commit 516e3cb in PR branch backport-12036-to-2.17 with baseline commit 87ce8ad in branch 2.17.

Found 9 performance improvements and 0 performance regressions! Performance is the same for 379 metrics, 2 unstable metrics.

scenario:iast_aspects-ospathbasename_aspect

  • 🟩 execution_time [-704.189ns; -657.879ns] or [-17.587%; -16.431%]

scenario:iast_aspects-ospathdirname_aspect

  • 🟩 execution_time [-865.059ns; -812.725ns] or [-19.193%; -18.032%]

scenario:iast_aspects-ospathsplitdrive_aspect

  • 🟩 execution_time [-278.534ns; -241.367ns] or [-9.197%; -7.970%]

scenario:iast_aspects-ospathsplitext_aspect

  • 🟩 execution_time [-753.124ns; -709.639ns] or [-17.402%; -16.397%]

scenario:iast_aspects-split_aspect

  • 🟩 execution_time [-223.491ns; -193.300ns] or [-11.649%; -10.075%]

scenario:iast_aspects-splitlines_aspect

  • 🟩 execution_time [-165.591ns; -132.943ns] or [-8.894%; -7.141%]

scenario:iast_aspects-swapcase_aspect

  • 🟩 execution_time [-293.008ns; -255.966ns] or [-9.054%; -7.910%]

scenario:iast_aspects-translate_aspect

  • 🟩 execution_time [-350.156ns; -307.556ns] or [-8.393%; -7.372%]

scenario:iast_aspects-upper_aspect

  • 🟩 execution_time [-298.187ns; -264.935ns] or [-9.883%; -8.781%]

@github-actions github-actions Bot added the stale label Apr 1, 2025
@erikayasuda erikayasuda closed this Apr 2, 2025
auto-merge was automatically disabled April 2, 2025 19:15

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog A changelog entry is not required for this PR. CI stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants