Skip to content

chore(ci): skip non-linux OCI package creation [backport 2.19]#12160

Closed
github-actions[bot] wants to merge 1 commit into2.19from
backport-12036-to-2.19
Closed

chore(ci): skip non-linux OCI package creation [backport 2.19]#12160
github-actions[bot] wants to merge 1 commit into2.19from
backport-12036-to-2.19

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

Backport af9098c from #12036 to 2.19.

The shared pipeline is introducing support for windows OCI packages. This PR ensure dd-trace-py doesn't generate nonsensical packages. Windows support can be added later.

This was tested by using the WIP branch of one-pipeline

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

The shared pipeline is introducing support for windows OCI packages.
This PR ensure dd-trace-py doesn't generate nonsensical packages.
Windows support can be added later.

This was tested by using the WIP branch of one-pipeline

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

---------

Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com>
(cherry picked from commit af9098c)
@github-actions github-actions Bot added changelog/no-changelog A changelog entry is not required for this PR. CI labels Jan 30, 2025
@github-actions github-actions Bot requested review from a team as code owners January 30, 2025 10:35
@randomanderson randomanderson enabled auto-merge (squash) January 30, 2025 10:56
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Jan 30, 2025

Benchmarks

Benchmark execution time: 2025-01-30 11:19:48

Comparing candidate commit 1dbea33 in PR branch backport-12036-to-2.19 with baseline commit aa1fbaa in branch 2.19.

Found 0 performance improvements and 2 performance regressions! Performance is the same for 392 metrics, 2 unstable metrics.

scenario:iast_aspects-translate_aspect

  • 🟥 execution_time [+271.317ns; +322.056ns] or [+7.023%; +8.337%]

scenario:iast_aspects-upper_aspect

  • 🟥 execution_time [+200.836ns; +242.132ns] or [+7.450%; +8.981%]

@github-actions github-actions Bot added the stale label Apr 1, 2025
@erikayasuda erikayasuda closed this Apr 2, 2025
auto-merge was automatically disabled April 2, 2025 19:14

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog A changelog entry is not required for this PR. CI stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants