feat(llmobs): support tracing bedrock converse stream#12873
Merged
Conversation
Contributor
|
|
Contributor
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 231 ± 3 ms. The average import time from base is: 233 ± 4 ms. The import time difference between this PR and base is: -2.0 ± 0.2 ms. Import time breakdownThe following import paths have shrunk:
|
BenchmarksBenchmark execution time: 2025-04-03 16:20:42 Comparing candidate commit 6df1cb2 in PR branch Found 2 performance improvements and 0 performance regressions! Performance is the same for 496 metrics, 2 unstable metrics. scenario:iast_aspects-format_map_aspect
scenario:iast_aspects-replace_aspect
|
emmettbutler
requested changes
Mar 25, 2025
Co-authored-by: Emmett Butler <723615+emmettbutler@users.noreply.github.com>
Co-authored-by: Emmett Butler <723615+emmettbutler@users.noreply.github.com>
…og/dd-trace-py into evan.li/bedrock-converse-streaming
Member
Kyle-Verhoog
left a comment
There was a problem hiding this comment.
just one suggestion, otherwise lgtm
wantsui
reviewed
Apr 2, 2025
wantsui
reviewed
Apr 2, 2025
wantsui
approved these changes
Apr 2, 2025
Kyle-Verhoog
approved these changes
Apr 2, 2025
Member
Kyle-Verhoog
left a comment
There was a problem hiding this comment.
just a nit but good from me
emmettbutler
approved these changes
Apr 3, 2025
chojomok
pushed a commit
that referenced
this pull request
Apr 7, 2025
Supports tracing `converse_stream` method from the bedrock converse API Since output messages, token information, and stop reason are all in the stream chunks returned by the API, we leave the responsibility to parse these out solely in `_extract_output_message_for_converse_stream`. This contains the bulk of the logic in the PR. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) --------- Co-authored-by: lievan <evan.li@datadoqhq.com> Co-authored-by: Emmett Butler <723615+emmettbutler@users.noreply.github.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supports tracing
converse_streammethod from the bedrock converse APISince output messages, token information, and stop reason are all in the stream chunks returned by the API, we leave the responsibility to parse these out solely in
_extract_output_message_for_converse_stream. This contains the bulk of the logic in the PR.Checklist
Reviewer Checklist