chore: set Python-specific injection package size ratchet#17256
chore: set Python-specific injection package size ratchet#17256gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits intomainfrom
Conversation
KowalskiThomas
left a comment
There was a problem hiding this comment.
Makes sense to me although I have little context; approving to unblock.
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
devflow unqueued this merge request: It did not become mergeable within the expected time |
This comment has been minimized.
This comment has been minimized.
Codeowners resolved as |
Description
Due to a change PHP-side libdatadog was bumped to v29. This version bump caused PHP images to blow past their previous limit.
Simultaneously, changes to the
datadog-packagebinary were picked up. Notably thegithub.com/klauspost/compress/zstddependency was bumped from 1.17.4 to 1.18.1. This bump included in 1.17.5 a default value change for the compression context size, downscaled from 32MB to 8MB (fixing compatibility with browsers like Chrome), causing drastic changes in compression results.Unbeknownst to the second change, PHP therefore updated the global limits, attributing the size change to the libdatadog bump (which was true, but not for the whole of it):
This allowed a change to slip through to other languages, where the new
datadog-packagebinary caused regressions in package size without change to the inputs. Due to the wildly differing sizes of packages across languages the regression is silent, rendering the size threshold ratchet moot.To combat such silently creeping regressions, this PR introduces language-specific thresholds for the ratchet through one pipeline overrides.
Testing
Shared pipeline should pass with the new thresholds in effect.
Risks
None
Additional Notes
datadog-packagewas fixed in https://github.com/DataDog/datadog-packages/pull/64 which may take some time to trickle down.