Skip to content

chore: set Python-specific injection package size ratchet#17256

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits intomainfrom
lloeki/injection-size-ratchet
Apr 2, 2026
Merged

chore: set Python-specific injection package size ratchet#17256
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits intomainfrom
lloeki/injection-size-ratchet

Conversation

@lloeki
Copy link
Copy Markdown
Member

@lloeki lloeki commented Apr 1, 2026

Description

Due to a change PHP-side libdatadog was bumped to v29. This version bump caused PHP images to blow past their previous limit.

Simultaneously, changes to the datadog-package binary were picked up. Notably the github.com/klauspost/compress/zstd dependency was bumped from 1.17.4 to 1.18.1. This bump included in 1.17.5 a default value change for the compression context size, downscaled from 32MB to 8MB (fixing compatibility with browsers like Chrome), causing drastic changes in compression results.

Unbeknownst to the second change, PHP therefore updated the global limits, attributing the size change to the libdatadog bump (which was true, but not for the whole of it):

This allowed a change to slip through to other languages, where the new datadog-package binary caused regressions in package size without change to the inputs. Due to the wildly differing sizes of packages across languages the regression is silent, rendering the size threshold ratchet moot.

To combat such silently creeping regressions, this PR introduces language-specific thresholds for the ratchet through one pipeline overrides.

Testing

Shared pipeline should pass with the new thresholds in effect.

Risks

None

Additional Notes

datadog-package was fixed in https://github.com/DataDog/datadog-packages/pull/64 which may take some time to trickle down.

@lloeki lloeki requested review from a team as code owners April 1, 2026 12:58
@lloeki lloeki requested review from avara1986 and emmettbutler April 1, 2026 12:59
@lloeki lloeki changed the title Set Python-specific injection package size ratchet chore: Set Python-specific injection package size ratchet Apr 1, 2026
Copy link
Copy Markdown
Contributor

@KowalskiThomas KowalskiThomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me although I have little context; approving to unblock.

@brettlangdon brettlangdon changed the title chore: Set Python-specific injection package size ratchet chore: set Python-specific injection package size ratchet Apr 1, 2026
@brettlangdon brettlangdon added the changelog/no-changelog A changelog entry is not required for this PR. label Apr 1, 2026
@brettlangdon
Copy link
Copy Markdown
Member

/merge

@gh-worker-devflow-routing-ef8351
Copy link
Copy Markdown

gh-worker-devflow-routing-ef8351 Bot commented Apr 2, 2026

View all feedbacks in Devflow UI.

2026-04-02 00:09:43 UTC ℹ️ Start processing command /merge


2026-04-02 00:09:48 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2026-04-02 04:55:08 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

@datadog-datadog-prod-us1

This comment has been minimized.

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot merged commit 454c0fe into main Apr 2, 2026
1062 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot deleted the lloeki/injection-size-ratchet branch April 2, 2026 14:29
@cit-pr-commenter-54b7da
Copy link
Copy Markdown

Codeowners resolved as

.gitlab-ci.yml                                                          @DataDog/python-guild @DataDog/apm-core-python

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog A changelog entry is not required for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants