Add msgpack Packer based off msgpack-python 0.6.2#3028
Merged
mergify[bot] merged 1 commit intoDataDog:masterfrom Nov 24, 2021
Merged
Add msgpack Packer based off msgpack-python 0.6.2#3028mergify[bot] merged 1 commit intoDataDog:masterfrom
mergify[bot] merged 1 commit intoDataDog:masterfrom
Conversation
Kyle-Verhoog
force-pushed
the
old-packer
branch
from
6175e65 to
806a538
Compare
Kyle-Verhoog
added
the
changelog/no-changelog
Kyle-Verhoog
force-pushed
the
old-packer
branch
5 times, most recently
from
9747137 to
dd467b6
Compare
It's handy to have a general msgpack encoder that can be used for encoding arbitrary payloads of primitive Python types (see DataDog#2915). It might be useful to use as a fallback for encoding traces as well if an issue with the custom msgpack encoder is suspected.
Kyle-Verhoog
force-pushed
the
old-packer
branch
from
dd467b6 to
23847b2
Compare
Codecov Report
@@ Coverage Diff @@
## master #3028 +/- ##
==========================================
+ Coverage 84.36% 84.46% +0.10%
==========================================
Files 624 633 +9
Lines 45397 45745 +348
==========================================
+ Hits 38298 38638 +340
- Misses 7099 7107 +8
Continue to review full report at Codecov.
|
P403n1x87
reviewed
Nov 24, 2021
| return 0 | ||
|
|
||
|
|
||
| cdef class Packer(object): |
Contributor
There was a problem hiding this comment.
This source file is already quite big. Would it make sense to put this into its own source file?
Member
Author
There was a problem hiding this comment.
Yeah I considered it but opted not to because, iirc, adding another Cython module significantly increases compilation time 😞. There's also quite a bit of dependence that Packer has that is shared with the other encoders (the underlying C struct and all the methods)
brettlangdon
approved these changes
Nov 24, 2021
P403n1x87
approved these changes
Nov 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message
{{title}}
It's handy to have a general msgpack encoder that can be used for
encoding arbitrary payloads of primitive Python types (see #2915).
The encoder added here is based off the one added in #1491.
It might be useful to use as a fallback for encoding traces as well if
an issue with the custom msgpack encoder is suspected.
The relevant tests from the msgpack-python implementation are included
as well to ensure that the implementation is correct.
Checklist