chore(protobuf): bump minimum version to 3.6.0#3559
Closed
Kyle-Verhoog wants to merge 1 commit intoDataDog:1.xfrom
Closed
chore(protobuf): bump minimum version to 3.6.0#3559Kyle-Verhoog wants to merge 1 commit intoDataDog:1.xfrom
Kyle-Verhoog wants to merge 1 commit intoDataDog:1.xfrom
Conversation
Kyle-Verhoog
force-pushed
the
bump-protobuf
branch
from
4bb434a to
67502d2
Compare
24 tasks
Kyle-Verhoog
changed the title
Kyle-Verhoog
changed the title
This is the minimum version that ddsketch supports.
Kyle-Verhoog
force-pushed
the
bump-protobuf
branch
from
67502d2 to
40db144
Compare
jd
suggested changes
Apr 8, 2022
Contributor
jd
left a comment
jd
left a comment
There was a problem hiding this comment.
It is totally unclear about why ddsketch dependencies impacts ddtrace?
Member
Author
|
yeah my description/motivation sucked lol, updated now! |
Member
Author
|
this is actually no longer required as we were able to get ddsketch to support protobuf 3.0: DataDog/sketches-py#48 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the minimum version that ddsketch supports, which will be a required dependency with #2915.
Motivation
In order to merge #2915 ddsketch needs to be added as a dependency.
ddtracepreviously minimally supported protobuf 3.0.0. ddsketch 2.0 minimally supports a much more recentprotobuf, 3.14. To meet roughly in the middle (and since tooling was still readily available for it) protobuf 3.6 was
chosen.
PR to update ddsketch: DataDog/sketches-py#48
(Unless we have a good reason to keep supporting 3.0.0 of protobuf which was released in July 2016.)