[opentracer] Tracer: start_span fixes#502
Merged
Kyle-Verhoog merged 3 commits intoopentracerfrom Jun 29, 2018
Merged
Conversation
- remove activation logic from start_span - refactor tests to use start_active_span instead
palazzem
reviewed
Jun 29, 2018
| ignore_active_span=ignore_active_span | ||
| ) | ||
|
|
||
| def _start_span(self, operation_name=None, child_of=None, references=None, |
There was a problem hiding this comment.
do we need this level of indirection? It's just another call in the stack without any immediate benefit (or at least I'm missing it)
palazzem
approved these changes
Jun 29, 2018
Kyle-Verhoog
added a commit
that referenced
this pull request
Sep 7, 2018
* refactor start_span documentation * fix: start_span should not activate the created span - remove activation logic from start_span - refactor tests to use start_active_span instead * match precedence to OT reference implementation
Kyle-Verhoog
added a commit
that referenced
this pull request
Sep 10, 2018
* refactor start_span documentation * fix: start_span should not activate the created span - remove activation logic from start_span - refactor tests to use start_active_span instead * match precedence to OT reference implementation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
start_spanshould not activate a span. This PR fixes this and adjusts the tests to usestart_active_spaninstead.