[SDTEST-3223] Use -c flag for git safe.directory instead of modifying global config #29
+49
−22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
-c safe.directory=<path>flaggetSafeDirectoryConfig()function that caches the repository root path (viasync.Once)execGit()andexecGitStringWithInput()to automatically include the safe.directory configgetLocalGitData()that was adding entries to global git configWhy
The previous approach modified the global git config by running:
This caused several problems:
--addcreates duplicate entries on repeated runsSolution
Instead of modifying global config, we now pass
safe.directoryas a command-line config override:Benefits:
sync.Oncefor performanceTest plan
make test)