Pulling configuration file #3749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l0k0ms
added
Architecture
…ataDog/documentation into gus/pulling-configuration-file
l0k0ms
removed
Do Not Merge
davidejones
approved these changes
Jan 14, 2019
Member
davidejones
left a comment
davidejones
left a comment
There was a problem hiding this comment.
There is a lot of format changes in this file so it was a bit trickier to see the changes.
I tested with a new cloned repo, using my github token and then using local repos and both worked fine. So this should be good to go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refactors the
update_pre_build()script in order to create apull_config.yamlfile that defines all content that is pulled and how it should be processed with the doc.Motivation
Allowing to scrap more content for the doc moving forward.
Preview link