Rewrite internal imports from hectane/go-acl to DataDog/go-acl#3
Merged
Rewrite internal imports from hectane/go-acl to DataDog/go-acl#3
Conversation
Updates apply.go and util.go to import the api subpackage from this fork's path instead of upstream's. Without this, consumers importing github.com/DataDog/go-acl still transitively pull github.com/hectane/go-acl/api from upstream, defeating the supply-chain goal of the fork (a self-contained, tagged release). Also updates README examples and the GoDoc badge to reference the fork.
KevinFairise2
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spotted by Codex on the consumer-side migration PR (datadog-agent#49932).
Problem
The fork's
go.moddeclaresmodule github.com/DataDog/go-acl, but the source filesapply.goandutil.gostill importgithub.com/hectane/go-acl/api(the api subpackage). As a result, any consumer importinggithub.com/DataDog/go-acltransitively pullsgithub.com/hectane/go-acl/apifrom upstream, defeating the supply-chain goal of the fork.Verified on the consumer side:
Change
apply.go,util.go:github.com/hectane/go-acl/api→github.com/DataDog/go-acl/apiREADME.md: GoDoc badge + import examples updated for consistencyappveyor.ymlstill references the upstream clone path; left untouched since it's dead CI config (the badge points at upstream's AppVeyor build, which we don't run).After merge
v1.0.0tag and GitHub release.v1.0.0at the new merge commit.dda inv tidywill drop thehectane/go-acl // indirectentry frompkg/util/filesystem/go.modand other non-OTel modules.