Skip to content

feat: seed root session ID for stable telemetry headers #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
khanayan123 merged 9 commits into from
Apr 22, 2026
Merged

feat: seed root session ID for stable telemetry headers #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7f548bb
feat: seed root session ID from master-generated RuntimeID
khanayan123 Apr 8, 2026
6ab57c4
fix: remove submodule pin, keep only conf.cpp change
khanayan123 Apr 13, 2026
597043b
chore: update dd-trace-cpp submodule to main (includes #295)
khanayan123 Apr 13, 2026
4c95bb0
Merge remote-tracking branch 'origin/main' into ayan.khan/stable-sess…
khanayan123 Apr 15, 2026
c70b5b6
chore: merge main and update dd-trace-cpp submodule to latest
khanayan123 Apr 15, 2026
24e8786
fix(test): pass vcr_json_body_normalizers to make_app
khanayan123 Apr 21, 2026
6cb1805
fix(test): bump ddapm-test-agent to v1.50.1 in requirements.txt
khanayan123 Apr 22, 2026
37e05c2
chore: bump dd-trace-cpp submodule to latest main (5dfaf40)
khanayan123 Apr 22, 2026
99afdb1
Merge remote-tracking branch 'origin/main' into ayan.khan/stable-sess…
khanayan123 Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion deps/dd-trace-cpp
Open in desktop
Submodule dd-trace-cpp updated 24 files
+0 −0 .github/dependabot.yml.disabled
+0 −50 .github/workflows/add_final_status.xsl
+1 −24 .github/workflows/dev.yml
+1 −1 .gitlab-ci.yml
+1 −1 .gitlab/config-registry.yml
+1 −0 BUILD.bazel
+17 −0 binding/c/include/datadog/c/tracer.h
+38 −0 binding/c/src/tracer.cpp
+27 −2 binding/c/test/test_c_binding.cpp
+13 −7 include/datadog/environment.h
+5 −0 include/datadog/telemetry/configuration.h
+6 −0 include/datadog/tracer_config.h
+14 −4 include/datadog/tracer_signature.h
+12 −0 src/datadog/root_session_id.h
+22 −0 src/datadog/telemetry/configuration.cpp
+53 −10 src/datadog/telemetry/telemetry_impl.cpp
+8 −0 src/datadog/telemetry/telemetry_impl.h
+5 −2 src/datadog/tracer.cpp
+2 −4 src/datadog/tracer_config.cpp
+77 −70 supported-configurations.json
+4 −1 test/mocks/http_clients.h
+27 −0 test/telemetry/test_configuration.cpp
+174 −1 test/telemetry/test_telemetry.cpp
+64 −23 tools/config-inversion/main.cpp
1 change: 1 addition & 0 deletions mod_datadog/src/tracing/conf.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ void init(TracerConfig& conf, RuntimeID& runtime_id, server_rec* s,
conf.service_type = "server";
conf.logger = std::make_shared<HttpdLogger>(s, datadog_module->module_index);
conf.runtime_id = runtime_id;
conf.root_session_id = runtime_id.string();
Comment on lines 15 to +16
Copy link
Copy Markdown
Contributor

@dmehala dmehala Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they share the same runtime id. is that expected?

Copy link
Copy Markdown
Contributor Author

@khanayan123 khanayan123 Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, intentionally root_session_id is seeded from the master's RuntimeID before forking so all workers share it as a stable correlation key, even though each worker gets its own runtime_id at tracer construction time

conf.integration_name = "httpd";
conf.integration_version = common::utils::make_httpd_version();
}
Expand Down
2 changes: 1 addition & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@ pytest==7.4.4
requests==2.32.2
flask==3.0.2
msgpack==1.0.8
git+https://github.com/Datadog/dd-apm-test-agent@v1.50.0
git+https://github.com/Datadog/dd-apm-test-agent@v1.50.1
Loading