Skip to content

Rewrite readiness-probe comment to be bug-agnostic #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pawelchcki wants to merge 1 commit into
base: pc/test-hang-fix
Choose a base branch
from
Open

Rewrite readiness-probe comment to be bug-agnostic #64

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions test/integration-test/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,11 +94,11 @@ def load_configuration(self, conf_path: str) -> bool:
# Continue anyway - sometimes apachectl returns non-zero but Apache starts
# We'll verify below with HTTP requests

# Probe readiness with a bare TCP connect rather than an HTTP GET —
# mod_datadog's `DatadogTracing Off` inside a <Location> is silently
# dropped by the config merge in common_conf.cpp (child Off is ORed
# with parent On), so any HTTP probe would emit a trace and pollute
# the per-test agent session.
# Probe readiness with a bare TCP connect rather than an HTTP GET:
# HTTP probes run through mod_datadog's handlers and can emit a
# trace into the per-test agent session, contaminating assertions
# tests make about per-request trace counts. A raw TCP connect
Copy link

Copilot AI Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor grammar: consider adding “that” to clarify the sentence (“…can emit a trace into the per-test agent session, contaminating assertions that tests make about per-request trace counts.”).

Suggested change
# tests make about per-request trace counts. A raw TCP connect
# that tests make about per-request trace counts. A raw TCP connect

Copilot uses AI. Check for mistakes.
# doesn't reach any request handler, so it stays out of traces.
import socket
max_wait = 5
start_time = time.time()
Expand Down
Loading