Upgrade pyyaml to 5.1#3698
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3698 +/- ##
==========================================
- Coverage 86.2% 82.75% -3.45%
==========================================
Files 729 93 -636
Lines 37497 5736 -31761
Branches 4494 667 -3827
==========================================
- Hits 32325 4747 -27578
+ Misses 3947 838 -3109
+ Partials 1225 151 -1074 |
8e75d37 to
b0fdbff
Compare
ofek
approved these changes
Apr 30, 2019
Member
Author
|
@ofek is this good to be merged? No need to manually bump versions or anything like that? |
Member
Author
|
Note: Further context on why the monkey patch has been kept in place follows. The pyyaml authors go on to say the following about the 5.1 release yaml/pyyaml#257): Because the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Bumps PyYaml to the latest 5.1.
Motivation
Enable new
full_load()option for customers perhaps wanting to use that afterload_all()was patched for security reasons.Notes:
Not sure how you guys are dealing with versioning at the moment! Please enlighten me! :)
Related PRs: DataDog/omnibus-software#311, DataDog/dd-agent#3839