[go_expvar] Fix path tag appended to all metrics matching path regex#472
Merged
[go_expvar] Fix path tag appended to all metrics matching path regex#472
Conversation
0b7f667 to
064835a
Compare
olivielpeau
previously approved these changes
Jun 13, 2017
Member
olivielpeau
left a comment
There was a problem hiding this comment.
Code LGTM! 👌
One comment on the changelog. Could you update manifest.json with the version bump too?
| 1.0.2 / Unreleased | ||
| ================== | ||
|
|
||
| * [BUGFIX] Fix path tag appended to all metrics matching path regex |
Member
There was a problem hiding this comment.
could you put this line in a new 1.0.3 section? 1.0.2 is what was shipped with 5.14.0
olivielpeau
approved these changes
Jun 13, 2017
olivielpeau
pushed a commit
that referenced
this pull request
Jun 15, 2017
gml3ff
pushed a commit
that referenced
this pull request
May 14, 2020
Flipping the attribute 'datadog''agent6' to true installs the agent6 instead of the agent5. Switching it back to false should reverse the operation as long as the agent 5 version is pinned.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix bug where each path matching the path regex of a metric would be added as a tag when an alias is set.
This would result in something like this :
instead of this :
for this yaml file :
Motivation
Discovered the bug while testing the scheduler in the new agent.
Testing Guidelines
An overview on testing
is available in our contribution guidelines.
Versioning
manifest.jsonCHANGELOG.mdAdditional Notes
Anything else we should know when reviewing?