Skip to content

Avoid calling profiler.stop() twice in ThreadFilterBenchmark #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhengyu123 merged 1 commit into from
Aug 7, 2025
Merged

Avoid calling profiler.stop() twice in ThreadFilterBenchmark #257

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions .../jmh/java/com/datadoghq/profiler/stresstest/scenarios/counters/ThreadFilterBenchmark.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,13 +103,6 @@ public void tearDown() {
Thread.currentThread().interrupt();
}

// Stop the profiler if it's active
try {
Copy link
Contributor

@r1viollet r1viollet Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to stop in tear down or setup in case it is still running ?

Copy link
Contributor Author

@zhengyu123 zhengyu123 Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not against that, but the framework (WhiteboxProfiler) handles it already.

profiler.stop();
} catch (IllegalStateException e) {
System.out.println("Profiler was not active at teardown.");
}

long endTime = System.currentTimeMillis();
long totalOps = operationCount.get();
double durationSecs = (endTime - startTime) / 1000.0;
Expand Down
Loading