Skip to content

Conversation

@zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented Aug 18, 2025

What does this PR do?:
Fix ./gradlew build task

Motivation:

Currently, run ./gradlew build from java-profiler repository results following error:

> Task :ddprof-lib:benchmarks:compileDebugMacosAarch64Cpp FAILED
In file included from /Users/zhengyu.gu/go/src/github.com/DataDog/java-profiler/ddprof-lib/benchmarks/src/unwindFailuresBenchmark.cpp:2:
In file included from /Users/zhengyu.gu/go/src/github.com/DataDog/java-profiler/ddprof-lib/src/main/cpp/unwindStats.h:5:
In file included from /Users/zhengyu.gu/go/src/github.com/DataDog/java-profiler/ddprof-lib/src/main/cpp/spinLock.h:20:
/Users/zhengyu.gu/go/src/github.com/DataDog/java-profiler/ddprof-lib/src/main/cpp/arch_dd.h:4:10: fatal error: 'arch.h' file not found
    4 | #include "arch.h"
      |          ^~~~~~~~
1 error generated.

This patch fixes above error.

Additional Notes:

How to test the change?:
Run ./gradlew build from java-profiler repo, build should succeed without error.

For Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles
    credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.
  • JIRA: [JIRA-XXXX]

Unsure? Have a question? Request a review!

@dd-octo-sts
Copy link

dd-octo-sts bot commented Aug 18, 2025

CppCheck Report

Errors (2)

Warnings (8)

Style Violations (299)

Copy link
Collaborator

@jbachorik jbachorik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zhengyu123 zhengyu123 merged commit ecb9ee6 into main Aug 19, 2025
97 checks passed
@zhengyu123 zhengyu123 deleted the zgu/fix-gradlew-build branch August 19, 2025 14:54
@github-actions github-actions bot added this to the 1.30.0 milestone Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants