Skip to content

Conversation

@zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented Sep 12, 2025

What does this PR do?:
This is the java-profiler side of fixing for benchmarking.

Motivation:
Enabling benchmarking on PR

Additional Notes:

How to test the change?:
Downstream build still triggered, no regression.

For Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles
    credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.
  • JIRA: PROF-11835 Fix the benchmarks

Unsure? Have a question? Request a review!

@zhengyu123 zhengyu123 marked this pull request as ready for review September 12, 2025 12:43
@pr-commenter
Copy link

pr-commenter bot commented Sep 12, 2025

Benchmarks

Parameters

Baseline Candidate
config baseline candidate
ddprof 1.31.0 1.32.0-zgu_fix-benchmark-SNAPSHOT
See matching parameters
Baseline Candidate
alloc off off
cpu on on
iterations 5 5
java
memleak off off
modes cpu,wall cpu,wall
wall on on

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 18 metrics, 1 unstable metrics.

@zhengyu123 zhengyu123 merged commit bfc63e0 into main Sep 12, 2025
94 checks passed
@zhengyu123 zhengyu123 deleted the zgu/fix-benchmark branch September 12, 2025 13:50
@github-actions github-actions bot added this to the 1.32.0 milestone Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants