Skip to content

Fix MacOSX signal handler #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhengyu123 merged 2 commits into from
Sep 23, 2025
Merged

Fix MacOSX signal handler #277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f4ca19
Fix MacOSX signal handler
zhengyu123 Sep 22, 2025
d61f338
Fix
zhengyu123 Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions ddprof-lib/src/main/cpp/os_dd.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,7 @@
namespace ddprof {
class OS : public ::OS {
public:
inline static SigAction replaceSigsegvHandler(SigAction action) {
return ::OS::replaceCrashHandler(action);
}

static SigAction replaceSigsegvHandler(SigAction action);
static SigAction replaceSigbusHandler(SigAction action);

inline static int getMaxThreadId(int floor) {
Expand Down
4 changes: 4 additions & 0 deletions ddprof-lib/src/main/cpp/os_linux_dd.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,10 @@ void ddprof::OS::mallocArenaMax(int arena_max) {
#endif
}

SigAction ddprof::OS::replaceSigsegvHandler(SigAction action) {
return ::OS::replaceCrashHandler(action);
}

SigAction ddprof::OS::replaceSigbusHandler(SigAction action) {
struct sigaction sa;
sigaction(SIGBUS, NULL, &sa);
Expand Down
8 changes: 6 additions & 2 deletions ddprof-lib/src/main/cpp/os_macos_dd.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,15 @@ void ddprof::OS::mallocArenaMax(int arena_max) {
}

SigAction ddprof::OS::replaceSigbusHandler(SigAction action) {
return ::OS::replaceCrashHandler(action);
}

SigAction ddprof::OS::replaceSigsegvHandler(SigAction action) {
struct sigaction sa;
sigaction(SIGBUS, NULL, &sa);
sigaction(SIGSEGV, NULL, &sa);
SigAction old_action = sa.sa_sigaction;
sa.sa_sigaction = action;
sigaction(SIGBUS, &sa, NULL);
sigaction(SIGSEGV, &sa, NULL);
return old_action;
}

Expand Down
Loading