Remove inotify-based TLS priming thread directory watcher #311
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
Removes the inotify-based thread directory watcher from the TLS priming system. This includes removing the
startThreadDirectoryWatcher()andstopThreadDirectoryWatcher()functions along with all associated implementation code across Linux and macOS platforms.Motivation:
The filesystem-based thread monitoring using inotify was causing performance overhead in production environments. This functionality will be replaced with library patching in the near future, providing a more efficient approach to native thread TLS initialization.
Additional Notes:
Changes made:
os_linux_dd.cppos_macos_dd.cppos_dd.hthread.cppto remove watcher initialization and cleanup callsThreadDirectoryWatchertest fromtest_tlsPriming.cppTlsPriming.mddocumentation to reflect the removal and document future directionHow to test the change?:
All C++ unit tests pass successfully, including the TLS priming tests:
gtestDebug- all 93 C++ unit tests passedFor Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!