ci: use github action that installs datadog-ci binary#52
Merged
calvinbayer merged 6 commits intomainfrom Apr 2, 2026
Merged
Conversation
…alling it via npx to prevent supply-chain attacks
- Remove unused node-version input parameter - Pass datadog-ci-version to install action's version parameter - Update datadog-ci-version default from "latest" to "v5" - Update README to reflect binary installation instead of npx - Remove node setup references from documentation This completes the transition from npx-based installation to using pre-built binaries, addressing the supply chain vulnerability in #49. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Extract version translation logic to scripts/translate-version.sh - Support legacy npm semver syntax (^, ~, >=, latest, .x) with deprecation warnings - Update test.yaml to remove node-version parameter - Add test-legacy-version-syntax job to verify backwards compatibility - Update documentation to note legacy syntax is supported but deprecated The translation layer will be removed in v3.0.0. Users should migrate to: - Major versions: v5 or 5 - Exact versions: v5.10.0 or 5.10.0 Fixes #49 - Eliminates supply chain vulnerability from runtime npm installs Fixes #31 - Removes setup-node dependency entirely Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Tags with special characters (>=, <, etc.) were being interpreted as operators by the Datadog API query, causing test validation to fail. Removed the version-specific tag since it's not needed for validation. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Add a sanitization step that replaces special characters with safe equivalents before using them in tags: - ^ → caret- - ~ → tilde- - >= → gte- - > → gt- - <= → lte- - < → lt- This prevents the Datadog API from interpreting these characters as comparison operators in queries, while still allowing us to track which version syntax was used in each test run. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
ypopovych
approved these changes
Apr 2, 2026
calvinbayer
deleted the
calvin.bayer/pin-datadog-ci-version-by-downloading-binary
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR eliminates the supply chain vulnerability caused by runtime
npxinstallation by switching to pre-builtdatadog-cibinaries. This change resolves the security issues described in #49 and #31.Changes Made
npx @datadog/datadog-ci@latestwith pre-built binary installation viaDataDog/install-datadog-ci-github-actionactions/setup-nodeentirely since the binary is self-containednode-versioninput and updateddatadog-ci-versionto use GitHub release tagsIssues Resolved
Fixes #49: Supply chain risk with runtime npm installs
The previous implementation used
npx @datadog/datadog-ci@latest, which resolved transitive dependencies fresh from npm on every workflow run with no lockfile protection. This exposed users to supply chainattacks like the malicious
axios@1.14.1incident.How this PR fixes it:
Fixes #31: Pin actions/setup-node to SHA
The issue requested pinning
actions/setup-nodeto a specific SHA for security.How this PR fixes it:
actions/setup-nodedependencySecurity Improvements
Before: Dependencies resolved at runtime via npm semver ranges
After: Self-contained binary with no runtime dependency resolution