update crashtracker and use new init function#36
Merged
Conversation
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
Overall package sizeSelf size: 30.57 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------|🤖 This report was automatically generated by heaviest-objects-in-the-universe |
|
|
||
| if (existsSync('/etc/alpine-release')) { | ||
| // TODO: Remove this when supported. | ||
| console.log('Received crash report with empty stack trace which is expected for Alpine.') |
There was a problem hiding this comment.
🟠 Code Quality Violation
Unexpected console statement. (...read more)
Debugging with console (such as console.log or console.info) is not considered a bad practice, but these statements can be accidentally left in production code, leading to unnecessary log pollution. It is important to remove or replace these debugging statements to maintain clean and secure production builds.
sanchda
approved these changes
Nov 8, 2024
sanchda
left a comment
sanchda
left a comment
There was a problem hiding this comment.
Reviewing from the libdatadog/crashtracking side.
Interfacing looks good. I ran tests under strace on my Linux machine and it seems like a reasonable interplay between the collector and receiver.
Looks good! Thank you!
bengl
requested changes
Nov 11, 2024
bengl
approved these changes
Nov 11, 2024
rochdev
added a commit
that referenced
this pull request
Nov 11, 2024
rochdev
added a commit
that referenced
this pull request
Nov 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I also had to switch to yarn because of a permission issue with npm and CentOS which I wasn't able to solve.