Add APIs for marking the crash as happened during profiler serialization#45
Merged
Add APIs for marking the crash as happened during profiler serialization#45
Conversation
Overall package sizeSelf size: 29.55 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------|🤖 This report was automatically generated by heaviest-objects-in-the-universe |
rochdev
approved these changes
Jan 13, 2025
szegedi
added a commit
that referenced
this pull request
Jan 15, 2025
szegedi
added a commit
that referenced
this pull request
Jan 16, 2025
BaptisteFoy
pushed a commit
that referenced
this pull request
Feb 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libdatadog has several
OpTypesfor annotating crashes with information on what the profiler was doing at the time.ProfilerSerializingis relevant to most crashes we observe with Node.js – setting it would addprofiler_serializing:1tag to the crashes making it easier to filter interesting ones.DataDog/dd-trace-js#5096 is the dd-trace-js component, and it is dependent on this being released first.
JIRA: PROF-11108